Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Activity (RSS)

Monday, May 12 2008
165 script/generate scaffold not creating missing folders was updated
  • Pratik
    • State changed from new to incomplete
    by Pratik at 12:47 AM

    Please submit a patch. Ideally speaking, one should take care of empty directories of a rails app while first committing to git.

    Thanks.

158 [FEATURE] Rails application recipe was updated
  • Pratik
    • State changed from new to invalid
    by Pratik at 12:46 AM

    I think you should release a gem to do so, which would basically install a new rails binary, maybe call it "railsgen" or something. Getting it in core might be...
156 Add rdoc task for activemodel was updated
  • Pratik
    Pratik commented at 12:36 AM

    Sounds good.

    Thanks.

Remove AR::Base#attributes argument. ... was committed by Repository at 12:36 AM
52 Remove argument from Base#attributes & deprecate was updated
  • Repository
    • State changed from new to resolved
    by Repository at 12:36 AM

    (from [d2212c1601dcd67e72e9d52f98347d3285fd7134]) Remove AR::Base#attributes argument. [#52 state:resolved]

    Signed-off-by: Pratik Naik

    http://github.com/rai...
Updated copyright years http://github... was committed by Repository at 12:34 AM
Making ready for RC1 release http://g... was committed by Repository at 12:30 AM
Deprecate AR::Base#attributes argumen... was committed by Repository at 12:27 AM
166 [PATCH] caches_action with conditional was updated
  • José Valim
    • Title changed from [PATCH] caches_action extension (with :if and :layout keys) to [PATCH] caches_action with conditional
    by José Valim at 12:26 AM

    :layout option removed! =)

    Should I do another patch just with the :layout option?

    And I don not know if would be important to document, but all parameters g...
No more svn version numbers to rely o... was committed by Repository at 12:22 AM
Depend on latest Rake http://github.c... was committed by Repository at 12:22 AM
157 [PATCH] "script/dbconsole" does not respect ERB in database.yml was updated
  • Pratik
    • State changed from new to resolved
    by Pratik at 12:13 AM
Sunday, May 11 2008
Merge branch 'master' of git@github.c... was committed by Repository at 11:59 PM
Ensure dbconsole respects erb in data... was committed by Repository at 11:59 PM
157 [PATCH] "script/dbconsole" does not respect ERB in database.yml was updated
  • Repository
    Repository commented at 11:59 PM

    (from [80e18e759e5244bbffd637e306f4f18b92af5caf]) Ensure dbconsole respects erb in database.yml. [#157 state:resolved] [Andrew Bennett]

    Signed-off-by: Pratik ...
156 Add rdoc task for activemodel was updated
  • Jake Howerton
    Jake Howerton commented at 11:55 PM

    Pratik,

    I can remove the hack from the main Rakefile and leave the new task in

    the AM rakefile, that way you can still cd into the AM dir and build

    the docs...
  • Pratik
    • State changed from new to hold
    • Title changed from [PATCH] Add rdoc task for activemodel to Add rdoc task for activemodel
    by Pratik at 10:27 PM

    I think we should abstain from adding AM related hacks. As AM holds a lot of work in progress, we should just wait.

    Thanks!

106 authenticity_token appears in URLs after AJAX GET request was updated
  • Pratik
    Pratik commented at 11:47 PM

    Chewi, have a look at request_forgery_protection_test.rb file. That should give you a rough idea.

    Thanks.

  • James Le Cuirot
    James Le Cuirot commented at 11:22 PM

    I was going to add some but I think forgery protection is disabled during tests anyway?

  • Pratik
    • State changed from new to incomplete
    by Pratik at 10:46 PM

    The patch needs tests.

    Thanks!

166 [PATCH] caches_action extension (with :if and :layout keys) was updated
  • Michael Koziarski
    Michael Koziarski commented at 11:29 PM

    Could we have the patch without the :layout option? I'm not necessarily sold on that one prior to 2.1, but :if looks good.

  • Michael Koziarski
    • State changed from resolved to new
    by Michael Koziarski at 11:28 PM

    whoops

  • Repository
    • State changed from new to resolved
    by Repository at 11:22 PM

    (from [9a137506a1267ec5938fcec4d2ff135f15037459]) Added not to sanitize helper docs that it doesn't guarantee well-formed markup.

    Signed-off-by: Michael Kozia...
167 [Patch] Sanitize helper docs: well-formed markup not guaranteed was updated
  • Michael Koziarski
    • State changed from invalid to resolved
    by Michael Koziarski at 11:28 PM
  • Pratik
    Pratik commented at 11:26 PM

    Fixed it in http://github.com/rails/rails/co...

    But please feel free to help with docrails project if you feel like documenting more stuff.

    Thanks!

  • Pratik
    • State changed from new to invalid
    by Pratik at 11:19 PM

    Could you please send me ('lifo') a PM at github and I'll add you to http://github.com/lifo/docrails so that you can commit the patch yourself.

    Thanks!

  • Michael Schuerig
    Michael Schuerig created the ticket at 11:15 PM

    Add note to docs for sanitize helper method that well-formed markup is not guaranteed.

130 CGI::Cookie and CookieStore performing unnecessary work causing interoperabil... was updated
  • Pratik
    • Assigned user set to Jeremy Kemper
    by Pratik at 11:23 PM
  • Rich Cavanaugh
    Rich Cavanaugh commented at 11:19 PM

    It would be simple enough to make this work with existing cookies. Would a patch implementing this be likely to be accepted?

  • Pratik
    • State changed from new to invalid
    by Pratik at 10:33 PM

    This is not a backward compatible change and will cause all existing cookie sessions to raise CGI::Session::CookieStore::TamperedWithCookie exception.

    Thanks....
Added not to sanitize helper docs tha... was committed by Repository at 11:22 PM
12 Bounded params in find(...:from) was updated
  • Pratik
    • State changed from new to invalid
    by Pratik at 11:20 PM

    The patch doesn't apply cleanly anymire.

    I think it'll be a good idea to discuss this patch/feature in the core mailing list.

    Thanks.

44 Custom resource paths was updated
  • Michael Koziarski
    • Milestone set to 2.1.1
    by Michael Koziarski at 11:11 PM
  • Pratik
    • State changed from new to incomplete
    by Pratik at 11:05 PM

    The patch doesn't apply clean anymore. Could you please and upload a new patch and use git-format-patch as well :) ?

    Also, what is the "stupid" bug being fixe...
108 [PATCH] change_table cleanup was updated
  • Matthew Boehlig
    Matthew Boehlig commented at 10:59 PM

    Documentation cleanup commited in:

    http://github.com/lifo/docrails/...

  • Matthew Boehlig
    Matthew Boehlig commented at 9:35 PM

    Will do.

    I was trying to guess the author's original intention, but it makes sense to leave the API as is and I'll just cleanup the docs.

  • Pratik
    • State changed from new to incomplete
    by Pratik at 9:25 PM

    Nice work!

    I don't think a new alias 'reference' is needed. The fix should to be change the docs where it says 'reference'.

    Probably, you can make your doc f...
114 Namespaced models and STI was updated
  • Pratik
    • State changed from new to incomplete
    by Pratik at 10:45 PM

    Why the need to add new tables for tests ? It should be possible to use existing tables.

    Rest looks good.

    Thanks!

When preloading group by reflection r... was committed by Repository at 10:16 PM
125 Eager loading load association for every STI subclass when it is declared in ... was updated
  • Repository
    • State changed from new to resolved
    • Title changed from [PATH] Eager loading load association for every STI subclass when it is declared in superclass to Eager loading load association for every STI subclass when it is declared in superclass
    by Repository at 10:16 PM

    (from [236f0bb67adecbc1e6dac5258e4a8cb310ffd7a4]) When preloading group by reflection rather than by class [#125 state:resolved]

    This avoids extra queries whe...
90 Enhancement: Add support for named scopes with optional arguments was updated
  • Pratik
    • State changed from new to invalid
    by Pratik at 9:45 PM

    I don't like the idea of the patch because the proposed functionality is dependent on return value of a class method, which doesn't feel intuitive for anything...
160 Rails application recipes was updated
  • Sven Fuchs
    Sven Fuchs commented at 9:38 PM

    How about a bash script? Or a rake task?

120 ActiveRecord calculations only accept one grouping field was updated
  • Pratik
    • State changed from new to invalid
    • Title changed from [PATCH] ActiveRecord calculations only accept one grouping field to ActiveRecord calculations only accept one grouping field
    by Pratik at 9:37 PM

    I'm not hugely in favor of this patch because,

    a. It's not backward compatible. Well, not for me at least as I'm quite used to abuse :group using it somewhat ...
118 Add mailer assertions to Rails was updated
  • Pratik
    • State changed from new to invalid
    • Assigned user set to Pratik
    by Pratik at 9:29 PM

    Looks great. But your uploaded patch looks convoluted as it has some Assert_not_valid changes in it as well. Could you please upload a different patch ?

    Thank...
Fix blank conditions on AssociationCo... was committed by Repository at 9:04 PM
104 Fix blank conditions with find on AssociationCollection was updated
  • Repository
    • State changed from new to resolved
    by Repository at 9:04 PM

    (from [0cbdd96c349c56c47299ca3c2bfa5d8c4f5e5a11]) Fix blank conditions on AssociationCollection#find. [#104 state:resolved]

    Signed-off-by: Pratik Naik

    http:...
97 Enhancement: Add scope_options inspection method to named_scope was updated
  • Pratik
    Pratik commented at 8:42 PM

    And just for the records, I had changed the patch to remove scope_options and use existing proxy_options instead.

    Thanks.

162 Rails not handling links with & correctly was updated
  • Pratik
    • Assigned user changed from DHH to Pratik
    by Pratik at 8:40 PM
  • Pratik
    Pratik commented at 8:40 PM

    Why can't the fix be in page.redirect_to ?

135 Make ActiveRecord errors support full sentence messages was updated
  • Pratik
    • State changed from new to hold
    by Pratik at 8:39 PM

    We're revamping AR::Errors class with ActiveModel. So I'm keeping this on hold.

    Thanks.