Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Activity (RSS)

Tuesday, May 13 2008
166 caches_action with conditional was updated
  • Pratik
    • Title changed from [PATCH] caches_action with conditional to caches_action with conditional
    by Pratik at 12:06 PM
ScaffoldGenerator to create public/st... was committed by Repository at 10:51 AM
165 script/generate scaffold not creating missing folders was updated
  • Repository
    • State changed from open to resolved
    by Repository at 10:51 AM

    (from [9fb01ce4b194567e84fa2f8582410fc76720a31f]) ScaffoldGenerator to create public/stylesheets if missing. [#165 state:resolved]

    Signed-off-by: Pratik Naik ...
162 Rails not handling links with & correctly was updated
  • Pratik
    • State changed from new to incomplete
    by Pratik at 10:46 AM
  • Daniel Morrison
    Daniel Morrison commented at 3:23 AM

    -1

    & shouldn't be in your URLs, and if it is, it should be there for a reason.

    Rails is acting appropriately.

    If there's a bug in page.redirect_to, it shoul...
Remove unnecessary DeprecatedInstance... was committed by Repository at 10:44 AM
122 rails/init.rb doesn't get called for unpacked gems was updated
  • Cheah Chu Yeow
    Cheah Chu Yeow commented at 10:11 AM

    Looks like Mark Lyon's comment is being marked as spam incorrectly.

    Anyway, sorry about not having a patch, but I suggest we revert this commit [http://github...
180 fix remote_function url escaping was created
  • André Arko
    André Arko created the ticket at 7:59 AM

    The remote_function helper builds a JS call to Ajax.Update, but does not escape single quotes in the URL, leading to broken JavaScript if the URL has a single ...
179 URL helpers in functional tests aren't escaping ampersands by default was created
  • orangechicken
    orangechicken created the ticket at 7:54 AM

    Given a resource Thing, things_path(:param1 => 123, :param2 => 456) should output /things/?param1=123&param2=456, however, with 2.0.2, the url helpers in a...
178 Add documentation for Inflector.inflect was created
  • Yehuda Katz
    Yehuda Katz created the ticket at 7:43 AM

    I added some documentation for the class method Inflector.inflect

177 Regression of ticket #2888: habtm inserts duplicate rows into join table was created
  • Jerry Cheung
    Jerry Cheung created the ticket at 6:40 AM

    In revision r9248, there is a test_update_attributes_after_push_without_duplicate_join_table_rows

    in has_and_belongs_to_many_associations_test.rb that address...
176 2.1_RC1 won't load on stock leopard setup was updated
  • Mike Wyatt
    Mike Wyatt commented at 6:30 AM

    creating a new rails app an running 2.0.991 in vendor does seem to work though. I'll sort through the files trying to find the differences

  • Mike Wyatt
    Mike Wyatt created the ticket at 6:04 AM

    when running any of the server, about, console scripts rubygems aborts saying it can't load a gem that is already loaded. this doesn't happen when running free...
152 Routing optimisations break plugins that use ActionController::Base.default_u... was updated
  • Tom Adams
    Tom Adams commented at 5:28 AM

    It appears that it is still broken, however I've been unable to reconfirm this, it could be some screwy settings on my behalf. I've checked the code in the pat...
175 TimeWithZone#to_json should include time zone was created
  • Daniel Morrison
    Daniel Morrison created the ticket at 3:05 AM

    This patch includes the time zone information in the json representation for two reasons: consistency and usefulness.

    Consistency: DateTime includes the zone,...
Dirty attributes aren't cleared if sa... was committed by Repository at 1:05 AM
174 dirty objects shouldn't clear changed attributes after a save failure was updated
  • Repository
    • State changed from new to resolved
    by Repository at 1:05 AM

    (from [593e21d6aedcc05d744be4996bd7180edce57efe]) Dirty attributes aren't cleared if save fails. [#174 state:resolved]

    Signed-off-by: Jeremy Kemper

    http://g...
173 config.gem will not load gems with a hyphen in the name was updated
  • Tekin
    Tekin commented at 12:28 AM

    That's the ticket! Thanks, -1 for me...

Monday, May 12 2008
174 dirty objects shouldn't clear changed attributes after a save failure was created
  • Xavier Noria
    Xavier Noria created the ticket at 11:55 PM

    Dirty objects shouldn't clear changed attributes after a save failure.

173 config.gem will not load gems with a hyphen in the name was updated
  • Rich Cavanaugh
    Rich Cavanaugh commented at 11:55 PM

    Try:

    config.gem 'mislav-will_paginate', :lib => "will_paginate", :source => 'http://gems.github.com'

  • Tekin
    Tekin commented at 7:49 PM

    OK, I should read error messages a bit more carefully, looks like it's a problem with rubygems...

  • Tekin
    Tekin commented at 7:29 PM

    rake gems produces the following error:

    no such file to load -- git-rails

    /Library/Ruby/Site/1.8/rubygems/custom_require.rb:27:in `gem_original_require'

    /Li...
Don't double-escape cookie store data... was committed by Repository at 11:27 PM
130 CGI::Cookie and CookieStore performing unnecessary work causing interoperabil... was updated
  • Repository
    • State changed from open to resolved
    by Repository at 11:27 PM

    (from [a425cd147363a0e8d7e17177ef252dd760197f15]) Don't double-escape cookie store data. Don't split cookie values with newlines into an array. [#130 state:res...
  • Jeremy Kemper
    Jeremy Kemper commented at 11:14 PM

    I buy that. Thanks for clarifying, Rich.

  • Rich Cavanaugh
    Rich Cavanaugh commented at 10:52 PM

    Yeah, I agree but, taken in context CGI::Cookie is plainly broken and acting differently depending on how you initialize.

    When name is a string the value is a...
  • Jeremy Kemper
    Jeremy Kemper commented at 10:39 PM

    Sorry, I missed that. I have mixed feelings about changing this behavior for all cookie values. Backward compatibility applies to the cookie store only.

  • Rich Cavanaugh
    Rich Cavanaugh commented at 10:05 PM

    I actually did, it's called test_cookies_should_not_be_split_on_values_with_newlines

3 earlier changes…
  • Jeremy Kemper
    Jeremy Kemper commented at 10:03 PM

    Ah, I see. Could you include a test for that case? The patch looks good, otherwise.

  • Rich Cavanaugh
    Rich Cavanaugh commented at 9:55 PM

    @value is expected to be an array but if you pass "one\ntwo" to Array you get:

    Array("one\ntwo") # => ["one\n", "two"]

    Which gets written out in the cookie h...
  • Jeremy Kemper
    • State changed from invalid to open
    by Jeremy Kemper at 9:28 PM 
    -        @value = Array(name['value'])
+        @value = name['value'].kind_of?(String) ? [name['value']] : Array(name['value'])

    Why? Array('foo') == ['foo']...
Simpler rescue_action condition http:... was committed by Repository at 9:25 PM
Use #duplicable? instead of anonymous... was committed by Repository at 9:25 PM
Ruby 1.9 compat: define __setobj__ fo... was committed by Repository at 9:25 PM
165 script/generate scaffold not creating missing folders was updated
  • Pratik
    • State changed from incomplete to open
    by Pratik at 2:16 PM
  • Matt Brindley
    Matt Brindley commented at 2:38 AM

    I've attached a patch to create public/stylesheets if it doesn't already exist.

    I believe the others are created if they don't exist already? I've tried delet...
171 Documentation fix for cached_attributes was updated
  • Pratik
    • State changed from new to invalid
    by Pratik at 12:51 PM

    Hi,

    You don't really need to create a patch here :) Just send me ( 'lifo' ) a PM at github and I'll add you to commit list.

    Thanks!

  • gaurav (at norbauer)
    gaurav (at norbauer) created the ticket at 12:49 PM

    Adding documentation for couple of methods in active_record/attribute_methods.rb

93 Restore timestamps in model rollback was updated
  • Xavier Noria
    Xavier Noria commented at 10:39 AM

    Oh yes much better, I'll rewrite it.

  • Pratik
    Pratik commented at 2:16 AM

    I wonder if it'd possible to use existing stored old values from Dirty module ?

    Thanks.

170 PostgreSQL: update rake tasks to use full settings from database.yml - bugfix was created
122 rails/init.rb doesn't get called for unpacked gems was updated
98 h method is not aliased properly was updated
  • Aamer
    Aamer commented at 7:16 AM

    Fair enough. In that case, I can't really write a performance-based test, so any other suggestions would be welcome.

  • Jeremy Kemper
    Jeremy Kemper commented at 7:10 AM

    but what is the point of redefining a method if you're not changing any functionality?

    to improve performance

  • Aamer
    Aamer commented at 6:20 AM

    The thing is that I cannot really write a test for it unless I redefine ERB::Util::HTML_ESCAPE, because there is no loss in functionality. The only time the t...
168 [PATCH] Generators create tests with require 'test_helper' which doesn't work. was updated
  • Jeremy Kemper
    • State changed from new to invalid
    by Jeremy Kemper at 7:08 AM

    Include the test dir in the load path: ruby -Itest test/units/foo_test.rb

    Or invoke the test via the test task: rake TEST=test/units/foo_test.rb

  • Brian Hogan
    Brian Hogan created the ticket at 4:31 AM

    The generators all create tests that use

    require 'test_helper'

    Howegver, when you run the tests in TextMate or at the command-line via ruby test/units/foo_te...
154 [PATCH] add authenticity_token in auto_complete was updated
138 script/generate glitch for controllers in modules was updated
  • Amol Hatwar (rubygem)
    Amol Hatwar (rubygem) commented at 2:30 AM

    OK, I seem to have gotten rid of this bug to some extent. What I couldn't fix (yet), is having a controllers nested within modules with the same names which is...
Prepare for 2.0.3 http://github.com/r... was committed by Repository at 12:51 AM