Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Daniel Morrison

Daniel Morrison

Not a member

Daniel Morrison's latest activity

Saturday, February 26 2011
6474 Convert csrf_meta_tags to use the tag helper was created in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison created the ticket at 6:47 PM

    csrf_meta_tags is one of the few places that use an html string and not the tag helper. Seems like it should for consistency (and for picking up overrides to th...
Saturday, January 17 2009
1773 Allow returning nil from a named_scope lambda was updated in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison commented at 3:39 PM

    +1

    Looks good, and I've definitely wanted this pattern more than once.
Thursday, August 07 2008
537 allow config.action_controller.filter_parameter_logging in environment.rb was updated in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison commented at 3:43 PM

    Gaius,

    I definitely disagree. In production, it is more important as you are accepting real passwords, credit cards, and SSNs.

    If you're storing credit card ...
Monday, August 04 2008
755 Dirty Tracking (partial updates) don't see decimal column updates was created in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison created the ticket at 4:45 PM

    Changing a decimal column (which gets turned into a BigDecimal) doesn't show up as a change for partial updates.

    I've included a failing test case. I don't ha...
Wednesday, July 02 2008
537 allow config.action_controller.filter_parameter_logging in environment.rb was updated in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison commented at 7:25 PM

    I really like it. +1

    Personally, I'd like to see :password set by default to encourage it as a best-practice. (maybe :ssn, and :credit_card too, but those are...
Sunday, June 15 2008
426 Eliminate extra queries when using Optimistic Locking with Partial Updates was created in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison created the ticket at 9:41 PM

    If you use optimistic locking with partial updates, you get extra queries where they aren't needed.

    Example (save a person without updates): 

    Person.first
Pe...
Monday, June 09 2008
287 Associations' dynamic finders fail with :order depends on :include was updated in Ruby on Rails
Tuesday, May 13 2008
175 TimeWithZone#to_json should include time zone was updated in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison commented at 3:22 PM

    My thought is simply that including the offset gives you more meaningful data, and you can easily convert to UTC if you want it.

  • Daniel Morrison
    Daniel Morrison created the ticket at 3:05 AM

    This patch includes the time zone information in the json representation for two reasons: consistency and usefulness.

    Consistency: DateTime includes the zone,...
162 Rails not handling links with & correctly was updated in Ruby on Rails
  • Daniel Morrison
    Daniel Morrison commented at 3:23 AM

    -1

    & shouldn't be in your URLs, and if it is, it should be there for a reason.

    Rails is acting appropriately.

    If there's a bug in page.redirect_to, it shoul...