This project is archived and is in readonly mode.
Associations' dynamic finders fail with :order depends on :include
This ticket was originally submitted on trac
Dynamic finders generate invalid queries when they are called on an association like: has_many :posts, :include => :comments, :order_by => 'comments.position' because :include is getting ignored. (using non-dynamic #find() works correctly)
I've attached test cases that cause this error and a patch to fix it. Tested against Trunk.
-
-
Rick- Milestone set to 2.1.1
- State changed from new to open
- Assigned user set to Rick
Can you create a git patch? See the docs on contributing.
-
Brandon KeepersUpdated patch for latest changes in edge rails and exported using git-format-patch
-
Brandon Keepers
Doh, just realized I committed the change to the mysql connection info. Path updated
-
Rick
- State changed from open to committed
Hey, I've got this pushed to my own fork. I started pushing some config.gem tweaks there so others could play with them, before they were finalized in rails core. If I was smart, I would've put them in a branch so that I don't have other patches like this one stuck in limbo. We'll merge it back in for 2.1.1 though.
Thanks.
-
Jeremy KemperCould you cherry-pick to master, Rick?
-
Brandon Keepers
Any way we can get this pushed or cherry-picked into the main repo?
-
Jeremy Kemper
It should be cherry-picked to 2-1-stable as well.
-
Rick
Pushed, but I don't see a 2-1 stable branch.
-
Rick
- State changed from committed to resolved