This project is archived and is in readonly mode.
String#parameterize should accept a custom separator
This tiny patch allows String#parameterize to receive an argument as ActiveSupport::Inflector.parameterize does.
Also added tests for String#parameterize as they were missing.
-
Yaroslav Markin- Assigned user set to Pratik
I believe this is already done, can we close?
activesupport/lib/active_support/inflector.rb 259: def parameterize(string, sep = '-') -
Frederick CheungI don't think that's the point - The point is that String#parameterize doesn't allow you to specify the separator argument that is passed to Inflector.parameterize
-
Miha FilejYaroslav, the code you cited refers to activesupport/lib/active_support/inflector.rb which is not affected by the patch.
The purpose of this ticket is to allow
some_string.parameterize("_") # instead of "La, la, la!".parameterize.dasherize # or ActiveSupport::Inflector.parameterize "La, la, la!", "_"Would anyone consider applying if I rebase the patch against master?
-
Miha Filej
"dasherize" should be "underscore". And also Frederick was quicker than me :)
-
PratikI don't think the tests for this need to use mocking/stubbing.
Thanks.
-
Miha Filej
So should I just test for some output? Because this is kinda already done in InflectorTest#test_parameterize.
-
Pratik
So should I just test for some output
Yes please :)
-
-
Sam GranieriI also made a fix for this problem... probably should not have duplicated efforts
-
Cheah Chu Yeow- Tag changed from activesupport, core_ext, patch, tests, tiny to activesupport, core_ext, duplicate, patch, tests, tiny
Since Sam's patch from http://rails.lighthouseapp.com/p... has been committed, I guess we should close this ticket.
-
Pratik
- State changed from new to duplicate