#1111 String#parameterize should accept a custom separator - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1111 ✓duplicate

String#parameterize should accept a custom separator

Reported by Miha Filej | September 25th, 2008 @ 03:46 PM | in 2.x

This tiny patch allows String#parameterize to receive an argument as ActiveSupport::Inflector.parameterize does.

Also added tests for String#parameterize as they were missing.

string_parameterize_custom_separator.diff 2 KB

Comments and changes to this ticket

You flagged this item as spam.
Yaroslav Markin December 25th, 2008 @ 09:12 PM
- Assigned user set to “Pratik”
I believe this is already done, can we close?
```
activesupport/lib/active_support/inflector.rb
259:    def parameterize(string, sep = '-')
```
Frederick Cheung December 25th, 2008 @ 09:50 PM
I don't think that's the point - The point is that String#parameterize doesn't allow you to specify the separator argument that is passed to Inflector.parameterize
You flagged this item as spam.
Miha Filej December 25th, 2008 @ 09:52 PM
Yaroslav, the code you cited refers to activesupport/lib/active_support/inflector.rb which is not affected by the patch.

The purpose of this ticket is to allow
```
some_string.parameterize("_")
# instead of
"La, la, la!".parameterize.dasherize
# or
ActiveSupport::Inflector.parameterize "La, la, la!", "_"
```
Would anyone consider applying if I rebase the patch against master?
You flagged this item as spam.
Miha Filej December 25th, 2008 @ 09:55 PM
"dasherize" should be "underscore". And also Frederick was quicker than me :)
Pratik December 25th, 2008 @ 09:58 PM
I don't think the tests for this need to use mocking/stubbing.

Thanks.
You flagged this item as spam.
Miha Filej December 25th, 2008 @ 10:07 PM
So should I just test for some output? Because this is kinda already done in InflectorTest#test_parameterize.
Pratik December 25th, 2008 @ 10:08 PM
So should I just test for some output

Yes please :)
You flagged this item as spam.
Miha Filej December 25th, 2008 @ 10:31 PM
done:)
- 0001-Make-String-parameterize-accept-a-custom-separator.patch 1.9 KB
You flagged this item as spam.
Sam Granieri March 6th, 2009 @ 08:36 PM
I also made a fix for this problem... probably should not have duplicated efforts

http://rails.lighthouseapp.com/p...
You flagged this item as spam.
Cheah Chu Yeow May 12th, 2009 @ 06:11 PM
- Tag changed from “activesupport, core_ext, patch, tests, tiny” to “activesupport, core_ext, duplicate, patch, tests, tiny”
Since Sam's patch from http://rails.lighthouseapp.com/p... has been committed, I guess we should close this ticket.
Pratik May 12th, 2009 @ 06:12 PM
- State changed from “new” to “duplicate”