This project is archived and is in readonly mode.
Format extensions (.xml or .json) should be optional in request urls generated in ActiveResource
Per REST, the http request headers provide the definitive information on what type of data to return ie "Accept:application/json" or "Accept:application/xml", so adding this information to the request urls should be optional. I added a configuration option to do so ie ActiveResource::Base.use_format_extension = false.
This patch maintains backwards-compatibility and by-default continues to build urls which include the format extensions. You can turn off the extensions in the urls by doing something like
Person.use_format_extension = false
OR
class FooBar < ActiveResource::Base self.use_format_extension = false end
-
PratikLooks good. The patch is missing docs.
-
rbpandeyUpdated patch and added documentation.
-
rbpandey
Pratik, can you also have a look at tickets 1150 and 1098 here http://rails.lighthouseapp.com/p...
Thx, rbp
-
rbpandey
Just wanted to touch this as a reminder that the patch was updated recently to include the requested documentation and rebased...
-
-
Nathaniel BiblerJust a word of warning that relying on
Acceptheaders alone may be quite misleading. Both Internet Explorer (pretty much all versions) and Webkit-based browsers often have incorrectAcceptrequest headers.Webkit actually prefers (or at least did if it hasn't yet been patched) XML before XHTML before HTML for general requests. And IE is just, well, retarded about life and Accepts image formats and even
application/mswordMIMEs before HTML. Way to go, IE. -
-
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale