Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

This project is archived and is in readonly mode.

[PATCH] Return processing lock to dispatcher. This fixes class reloading race in development mode

#1170

The problem is that even if concurrency is turned off, class reloading in development mode is not guarded by any lock.

This causes errors like this 'NameError: uninitialized constant ActionController' because classes are being reloaded while action tries to make use of them

Also available here http://github.com/alk/rails/comm...

Reported by Aliaksey Kandratsenka · October 4th, 2008 @ 03:30 PM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Aliaksey Kandratsenka
    Aliaksey Kandratsenka
    • Tag changed from activerecord, patch, race to actionpack, patch, race

    Uploading new patch which doesn't remove allow_concurrency flag

    October 4th, 2008 @ 05:18 PM

  2. Repository
    Repository
    • State changed from new to committed

    (from [b437a7d34e86c16a211171d491e805b603f0dc99]) Return processing lock to dispatcher, the finer grained lock was incompatible with the reloading in development mode.

    This commit also adds ActionController::Dispatcher#dispatch_unlocking -- non-locking version of dispatch. It's named anologously to POSIX {getc,getchar,...}_unlocked functions.

    Signed-off-by: Michael Koziarski michael@koziarski.com [#1170 [PATCH] Return processing lock to dispatcher. This fixes class reloading race... state:committed] http://github.com/rails/rails/co...

    October 4th, 2008 @ 05:37 PM