Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] Fix performance bug in AttibuteMethods#respond_to? in handling of private methods

#1173

We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm.

It turns out that self.private_methods.include?(method) is several orders of magnitude slower than respond_to?

Reported by Aliaksey Kandratsenka · October 4th, 2008 @ 03:44 PM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Repository
    Repository
    • State changed from new to committed

    (from [f550c8625739106e957e4260d3d592a9665fc943]) Fix performance bug in AttibuteMethods#respond_to? in handling of private methods

    We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm.

    Signed-off-by: Michael Koziarski michael@koziarski.com [#1173 [PATCH] Fix performance bug in AttibuteMethods#respond_to? in handling of pri... state:committed] http://github.com/rails/rails/co...

    October 4th, 2008 @ 04:49 PM