This project is archived and is in readonly mode.
[PATCH] Fix performance bug in AttibuteMethods#respond_to? in handling of private methods
Reported by Aliaksey Kandratsenka | October 4th, 2008 @ 03:44 PM | in 2.x
We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm.
It turns out that self.private_methods.include?(method) is several orders of magnitude slower than respond_to?
Comments and changes to this ticket
-
Repository October 4th, 2008 @ 04:49 PM
- State changed from “new” to “committed”
(from [f550c8625739106e957e4260d3d592a9665fc943]) Fix performance bug in AttibuteMethods#respond_to? in handling of private methods
We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm.
Signed-off-by: Michael Koziarski michael@koziarski.com [#1173 state:committed] http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Aliaksey Kandratsenka
Repository
Attachments
Tags
Referenced by
-
1173
[PATCH] Fix performance bug in AttibuteMethods#respond_to? in handling of private methods
Signed-off-by: Michael Koziarski michael@koziarski.com [#...