#1218 [PATCH] :path_names could be used to customize collection actions too - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1218 ✓committed

[PATCH] :path_names could be used to customize collection actions too

Reported by Nicolas Blanco | October 15th, 2008 @ 02:47 PM | in 2.3.4

For now :path_names is used to customize member actions in resources routing.

Is there a good reason it is not used to customize collection actions too?

I've tested on a simple project with rails edge frozen to copy/paste the two lines from map_member_actions that read the action_path from :path_names to map_collection_actions and it seems to work well.

I think I'll test this later and make a small patch.

Thanks. Nicolas.

Comments and changes to this ticket

You flagged this item as spam.
Bence Nagy December 27th, 2008 @ 10:33 PM
- Tag changed from “actionpack, resources” to “actionpack, patch, resources”
I made the patch for this, actionpack tests run fine.
- path_names_with_collections.diff 1.3 KB
Pratik March 7th, 2009 @ 12:06 PM
- Assigned user set to “Pratik”
- State changed from “new” to “incomplete”
Looks ok. Patch is missing tests and docs though.

Thanks!
CancelProfileIsBroken August 5th, 2009 @ 03:02 PM
- Tag changed from “actionpack, patch, resources” to “actionpack, bugmash, patch, resources”
You flagged this item as spam.
Hugo Peixoto August 9th, 2009 @ 06:32 AM
I've attached a patch that contains Nicolas's code and that adds tests and documentation.
- 1218-path_names_with_collections.diff 5 KB
You flagged this item as spam.
Kieran P August 9th, 2009 @ 06:58 AM
+1 Patch applies cleanly to 2-3-stable, but not to master. Uploading patch that applies to master.
- 1218_path_names_master.patch 4.5 KB
You flagged this item as spam.
Kieran P August 9th, 2009 @ 07:10 AM
- Title changed from “:path_names could be used to customize collection actions too” to “[PATCH] :path_names could be used to customize collection actions too”
CancelProfileIsBroken August 9th, 2009 @ 11:48 AM
- Assigned user changed from “Pratik” to “Michael Koziarski”
- State changed from “incomplete” to “open”
Rizwan Reza August 9th, 2009 @ 08:06 PM
verified

+1 Kieran P's patch works perfectly on master. All tests pass.
Rizwan Reza August 9th, 2009 @ 08:12 PM
- Tag changed from “actionpack, bugmash, patch, resources” to “actionpack, bugmash, patch, resources, verified”
verified

+1 Hugo's patch works on 2-3-stable. All tests pass as well.
Repository August 9th, 2009 @ 10:27 PM
- State changed from “open” to “committed”
(from [39de15f13655ed78ed7149e8eb8721139a57d501]) Added both the documentation and a test case for the collection path name customization feature.

[#1218 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/39de15f13655ed78ed7149e8eb8721...
Repository August 9th, 2009 @ 10:27 PM
(from [202b091373ed4d6c78adc7af5e89a359ff0fff2d]) Added both the documentation and a test case for the collection path name customization feature.

[#1218 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/202b091373ed4d6c78adc7af5e89a3...
Jeremy Kemper August 9th, 2009 @ 10:29 PM
- Tag changed from “actionpack, bugmash, patch, resources, verified” to “actionpack, patch, resources, verified”
- Milestone changed from “2.x” to “2.3.4”
cherry-picked Hugo's commits straight to master