This project is archived and is in readonly mode.
Don't eval recognize_optimized as part of recognition_optimization.rb. It produces meaningless line numbers.
Passing FILE and LINE__ in eval of recognize_optimized mixes lines of recognition_optimization.rb and lines of generated code. This is not good.
This also produces line numbers greater than recognition_optimization.rb has, which causes rcov to trash memory outside of it's coverage counting arrays.
-
Pratik- Assigned user set to Michael Koziarski
- Title changed from [patch] don't eval recognize_optimized as part of recognition_optimization.rb. It produces meaningless line numbers. to Don't eval recognize_optimized as part of recognition_optimization.rb. It produces meaningless line numbers.
-
Repository- State changed from new to committed
(from [099f10679ec6d9ead9606cac2f843e854787db0c]) Don't eval recognize_optimized use FILE and LINE in the optimised recognition code.
It produces meaningless line numbers. This also easily produces line numbers greater than recognition_optimization.rb have, which causes rcov to trash memory outside of it's coverage counting arrays.
[#1319 Don't eval recognize_optimized as part of recognition_optimization.rb. It pro... state:committed] Signed-off-by: Michael Koziarski michael@koziarski.com http://github.com/rails/rails/co...