This project is archived and is in readonly mode.

#1321 ✓invalid
David Chelimsky

treat new records with equivalent attributes as equivalent (==)

Reported by David Chelimsky | November 3rd, 2008 @ 04:43 PM | in 2.x

If I want to specify that the 'new' action in my AccountsController assigns a new Account to @account, I'd instinctively do this:

get :new
assigns[:account].should ==

and expect this controller code to pass that code example:

def new
  @account =

But this fails because ActiveRecord::Base doesn't treat new records as equivalent (==), regardless of the values of their attributes.

$ script/console
$ ==
=> false
$ => 'admin') == => 'admin')
=> false

This means that the simple example above has to be more complex. Here's the solution I see most often (in my code and in others, regardless of testing and mocking frameworks used):

account =
get :new
assigns[:account].should == account

I think a reasonable approach would be to treat new records as equivalent (==) as long as they are both new records and have equivalent attributes (self.attributes == other.attributes).

This would make all of my rspec code examples much, much, much cleaner and less brittle, and I'm quite sure I'm not alone.

Now I'll admit that changing the meaning of == might seem to pose significant risk, but I made the change and the activerecord unittest suite still passes. The change only affects new records, and I can't imagine there would be many, if any, cases where application code would actually behave differently due to this change.

But that's just me :) I'm sure I'm not thinking of something.

In any case, solution can be found at>

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket