This project is archived and is in readonly mode.

#1342 ✓stale

active record associations

Reported by Daniel | November 7th, 2008 @ 04:20 AM | in 3.x

What's wrong with ruby associations?

Somehow association fields don't have any support for dirty objects nor optimistic locking.

I would expect dirty objects to work like this:

class Person has_many :cars end

person = Person.find_by_name("Jack")

=> [#][Car.find_by_name("Porsche"), Car.find_by_name("VW")]

=> [#, #]

person.changed? => true person.changes

=> {"cars"=>[[#], [#, #]]} #associations are saved in the database

However ror returns the following

person = Person.find_by_name("Jack")

=> [#][Car.find_by_name("Porsche"), Car.find_by_name("VW")] #associations are saved in the database

=> [#, #]

person.changed? => false person.changes

=> {}

The same problem happens with optimistic locking

p1 = Person.find_by_name("Jack") p2 = Person.find_by_name("Jack") = [Car.find_by_name("Porsche")] = [Car.find_by_name("BMW")]

I would expect the object to raise an exception, but it doesn't.

Isn't there a way to unify the behaviour of regular fields and associations? Most objects in my app don't represent flat tables, but tables that associate each other. Right now I'm forced to having to wrap many attribute updates into a transaction and write my own object comparisons.

Comments and changes to this ticket

  • Pratik

    Pratik March 12th, 2009 @ 04:00 PM

    • State changed from “new” to “incomplete”

    Can we please have a patch with failing tests ? should be helpful.

    Thanks !

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:51 PM

    • State changed from “incomplete” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:51 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket