This project is archived and is in readonly mode.
assert_response assumes a rendered template
-
Chris Hapgood
I am unable to post a comment that includes my ruby source code -LH blows up. But the code example is pretty simple: implement a rescue_action_in_public and render a string directly instead of a template. That's a common practices for XML and JSON error messages.
Also attaching a patch that fixes the problem. Tests to come.
-
Chris Hapgood
Here's a pastie of the code that causes LH to barf:
NB: Even if I remove the "@@@ ruby" tag, it doesn't help.
-
Chris Hapgood
I can write a failing test against 2.0.2, but to get one against edge is going to take me a while. Would 2.0.2 be good enough?
-Chris
-
Pratik
One against edge would be nicer. But if you can't, then 2.0.x is fine too and I'll try to port it to edge.
Thanks.
-
Chris Hapgood
Jeremy fixed this already in Edge (Commit eb837b52e34c1f7f0c71d704ffdb3e4eb4b582e2).
-
Chris Hapgood
Since I had gone to the trouble of writing a failing test before I found Jeremy's patch on Edge, I figured it would be a good idea to add the test anyway.
Attached is a patch against Edge that validates assert_response's behavior faced with a failure response but no exception.
-
Pratik
- State changed from incomplete to open
-
Repository
- State changed from open to resolved
(from [e6f5079a48094eeba3dab9dca52b16b58ddc3634]) Test for assert_response for failure response without an exception. [#141 state:resolved]
Signed-off-by: Pratik Naik
-
Jeff Kreeftmeijer
Automatic cleanup of spam.
