Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Normalize author names in CHANGELOGs

#1495

This patch normalizes author names in CHANGELOGs according to the map in http://gist.github.com/23458. That hash was built with many contributions from people in the core mailing list.

Reported by Xavier Noria · November 30th, 2008 @ 12:22 AM

State: committed
Milestone: 2.x
Assigned to: DHH DHH
Importance: none

Activity

  1. Chris Kampmeier
    Chris Kampmeier

    Nice, Xavier.

    If I want to fix my old trac username, which isn't included, should I just fork your gist? Or submit a new patch?

    November 30th, 2008 @ 01:40 AM

  2. Xavier Noria
    Xavier Noria

    Hi Chris, please just send me an email to fxn at hashref dot com. I'll update both the gists and this ticket.

    Also, if someone wants to add some normalization or have their name normalized in a different way just drop me a line!

    November 30th, 2008 @ 01:58 AM

  3. Xavier Noria
    Xavier Noria

    Great, I got the email and updated the patch. Thank you Chris!

    Also added "noradio" to Marcel's map and "xaviershay" -> "Xavier Shay".

    November 30th, 2008 @ 10:36 AM

  4. Xavier Noria
    Xavier Noria

    The original script looked for attributions at the end of lines, the most common place.

    Some of them were not there though, for instance

    ...when not given an options hash [DHH]. Examples:

    I refined the script to catch those ones as well without introducing false positives that I know of.

    Patch updated.

    November 30th, 2008 @ 08:08 PM

  5. Xavier Noria
    Xavier Noria

    git pull && patch again

    December 2nd, 2008 @ 07:03 PM

  6. Xavier Noria
    Xavier Noria

    git pull && patch

    December 5th, 2008 @ 07:57 AM

  7. Xavier Noria
    Xavier Noria

    git pull && patch

    December 9th, 2008 @ 11:54 PM

  8. Repository
    Repository
    • State changed from new to committed

    (from [46c7dd234807b2d24c8c742acb18c633b69e385d]) normalize author names in changelogs [#1495 Normalize author names in CHANGELOGs state:committed]

    Signed-off-by: David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/co...

    December 16th, 2008 @ 01:35 PM

  9. Brandon Keepers
    Brandon Keepers

    Here's one more. :)

    Should I open a new ticket for this?

    December 17th, 2008 @ 02:02 PM

  10. Xavier Noria
    Xavier Noria

    Hi Brandon, sorry for the delay!

    I am maintaining the mapping, which is an ongoing effort. See http://gist.github.com/20721 and http://gist.github.com/23458.

    >

    According to your patch I've added

    @@@ruby 'Brandon Keepers' => ['brandon', email('brandon', 'opensoul.org')],

    

After a while I'll prepare a new patch with new additions.

    December 20th, 2008 @ 11:15 PM

  11. Xavier Noria
    Xavier Noria

    Bah, I messed up the markup.

    December 20th, 2008 @ 11:17 PM