#1597 ActionView::Helpers::TextHelper#truncate should understand HTML encoding. - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1597 incomplete

ActionView::Helpers::TextHelper#truncate should understand HTML encoding.

Reported by Gaius Centus Novus | December 18th, 2008 @ 05:13 PM | in 3.x

I'd like to use the HTML ellipsis (…) as my :omission in #truncate. The problem is that #truncate views that as a string of length 7, not of length 1. That is,


truncate('A really long string', :length => 10, :omission => '&#8230;')
# => "A r&#8230;"

But since … is really a single character in HTML, it should output "A real…".

Comments and changes to this ticket

You flagged this item as spam.
Peter Wagenet December 18th, 2008 @ 07:52 PM
- Tag changed from “html, truncate, view” to “html, patch, tested, truncate, view”
The problem here is a bit more complicated that it seems. First, what if the user doesn't plan to format as HTML? I know that's an odd case, but should it be supported? If so, how do we know if "…" should be counted as one character or seven? If we do assume that it will always be output as HTML then counting it as one character is simple, as you can see in my attached patch. However, my patch does nothing about the case where we have special characters in the string to be truncated. Even worse, we could end up truncating in the middle of a special character which would be far from desired. There's probably the need for some additional work to be done here.
- truncate.diff 1.9 KB
You flagged this item as spam.
Peter Wagenet December 18th, 2008 @ 07:53 PM
The ellipses in my comment should actually be the HTML string written out.
Pratik December 22nd, 2008 @ 12:45 AM
- Assigned user set to “Pratik”
- State changed from “new” to “incomplete”
We could have used CGI::unescapeHTML here, except it doesn't seem to be working with &#8230. So if there is a rack equivalent of that, it could work here.

Thanks.
You flagged this item as spam.
Gaius Centus Novus December 22nd, 2008 @ 12:59 AM
CGI::unescapeHTML is completely borked. See my question on StackOverflow: http://stackoverflow.com/questio...
Jeremy Kemper May 4th, 2010 @ 06:48 PM
- Milestone changed from “2.x” to “3.x”
[bulk edit]
Ryan Bigg November 8th, 2010 @ 01:53 AM
- Tag cleared.
Automatic cleanup of spam.
You flagged this item as spam.
bingbing March 26th, 2011 @ 01:40 AM
omega watch