Preserve XML Attributes with Hash#from_xml and ActiveResource

So instead of taking a boolean take a hash that could also be used for other stuff later? That's not a bad idea. I'll see about changing this. I'll also check that it's all still compatible (and necessary) with 2.3.

Thanks. I think it's probably a little late to push this for 2.3. But I'll commit as soon as the 2.3 stable release is out.

Yeah, that's probably true. I'll take a look at 3.0 as well.

Here's the Rails 2.3 version anyway.

And here's the one for 3.0. The code is the same, but the patch wouldn't apply so I had to redo it.

While I like the general idea of this, the "content" key is troubling. What I'd like to see is a parsing of XML that preserves the difference between tag attributes and tag bodies.

In order to do this, it should separate the data into an (attributes, content) tuple.

Examples:

Hash.from_xml("<tag attr='val'>content</tag>", true) #=> {"tag"=> [{"attr" => "val"}, "content"]}

Hash.from_xml("<tag content='inline' attr='val'>actual content</tag>") #=> {"tag" => [{"content" => "inline", "attr" => "val"}, "actual content"]}

Nick: It would be nice to come up with a solution that couldn't possibly be generated by the current implementation. The tuple example you give fits that bill, but only in the case of an attribute. if "tag" were a nested resource instead, this would generate a list of hashes which already has a meaning.

I don't love an idea that requires looking at the hash keys themselves, but I think it might be necessary. How about something like this:

{"tag" => {:content => "actual content", :attributes => {"content" => "inline", "attr" => "val"} } }

So where does this stand?

This is a fundamental problem in Rails -- Hash.from_xml just isn't very XML savvy.

Elements can have multiple types of children, but there's 3 notable ones:
* attribute * element * #text e.g.
23

Now arguably you could state an Element -or- #text is handled, but not both. This matches with the notion a Hash key's value can be 'primitive'/atomic value (String/etc) or 'complex' (Hash) (or a list of either, i.e. Array).

But the notion of only handling child Attributes if child Elements exist is seriously flawed.

I'm not too fond of the key name (:content). Would be more accurate to call it :text or :value.
Even better, to avoid collisions (yes, I've seen XML like 2), how about an option to control the name of the key? ,eg.
Hash.from_xml(xml, :preserve_attributes => true, :text_value_keyname => :content) [or whatever you want to call it]

Gah! In my comment "Even better, to avoid collisions (yes, I've seen XML like 2)..." the '2' was supposed to be the XML block

@@@ XML 2

I'm sure everyone's seen XML ranging from pretty and elegant to really ugly and coarse, even down to things like







@@@XML
<ITEM TYPE='PURCHASEORDER'><ID VALUE='123'/></ITEM>

My point being, any (sane) name you pick for the #text's key in the Hash can collide with attributes in use in the real world, so pick a sane default and give callers the option to override the default key if they have to deal with a collision.

Grrrr. OK, the 'Formatting help' isn't -- it's still mangling my sample XML. Fine. Here's the previous comment, but with curly braces instead of angle brackets. Let's see if he handles that:

Gah! In my comment "Even better, to avoid collisions (yes, I've seen XML like 2)..." the '2' was supposed to be the XML block

{BLEH VALUE='1'}2{/BLEH}

I'm sure everyone's seen XML ranging from pretty and elegant to really ugly and coarse, even down to things like

@@@XML {ITEM TYPE='PURCHASEORDER'}{ID VALUE='123'/}{/ITEM}

My point being, any (sane) name you pick for the #text's key in the Hash can collide with attributes in use in the real world, so pick a sane default and give callers the option to override the default key if they have to deal with a collision.

I ran into this today. Bummer! Going to have to work around for sure.

Slightly related is that current implementation can't deal with arrays. See https://rails.lighthouseapp.com/projects/8994/tickets/3133-activere...

I need this too, will try and merge the patch into the current master and report back.

I like nick's suggestion for the syntax, if preserving XML attributes was an option that needed to be turned on, then I don't see why the same structure that could possibly be generated would be an issue.

Indeed, the problem still exists in Rails 3.0.1.

Instructions: download and untar to /sites/all/modules

also - Download and install 'Rules' module to /sites/all/modules

Run /update.php

Goto Admin>Build>Modules, enable "OA Single Group Login Redirect" module and allow Rules module to be activated when prompted.

Log-out as admin and log-in as user with 1 group - page redirects as expected.

Greyside Thank-you!

Thank you for this information,I like it very much,Would you lik a pair of
Pachuco Suits
pack linen clothes
pack suit into suit
pant length
pant length for men

paul smith mens suits
Welcome to our store,We have the best service team!

louis vuitton watches