This project is archived and is in readonly mode.
javascript_include_tag shouldn't append a ".js" onto external urls
the problem
javascript_include_tag("http://www.google.com/jsapi")
=> %(<script type="text/javascript" src="http://www.google.com/jsapi.js"></script>)
but that url isn't valid.
If we've specified an external url, then we should also have specified the extension if there is one.
All the tests seem to pass, and I don't seem to have broken the external asset-host functionality.
-
MatthewRudya recent commit changed the underlying code in asset_tag helper.
as such this patch no longer works
the offending code is;
if ext && (File.extname(source).blank? || File.exist?(File.join(ASSETS_DIR, dir, "#{source}.#{ext}"))) source += ".#{ext}" endI think it should be changed to exclude;
source += ".#{ext}" unless source =~ %r{^[-a-z]+://}however I need to dry up all these calls to %r{^[-a-z]+://}
something for the morning
-
Pratik- Assigned user set to Pratik
- State changed from new to incomplete
Patch doesn't apply anymore ( of course, it's been months :( ). But ok, I'll try to apply as soon as there's a new patch.
Thanks !
-
CancelProfileIsBroken
- Tag changed from actionpack, assets, asset_tag_helper, javascript to actionpack, assets, asset_tag_helper, bugmash, javascript
-
MatthewRudy
this just bit me again yesterday.
I should build a patch.
-
MatthewRudy
Ok,
here is it fixed for edge.BOOM!!
-
Repository
- State changed from incomplete to resolved
(from [64268a0b06d32567c6e88b7293f332b79e10414b]) Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" or ".css" onto external urls [#1664 javascript_include_tag shouldn't append a ".js" onto external urls state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/64268a0b06d32567c6e88b7293f332... -
CancelProfileIsBroken
- Tag changed from actionpack, assets, asset_tag_helper, bugmash, javascript to actionpack, assets, asset_tag_helper, javascript