Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  MatthewRudy January 5th, 2009 @ 02:11 AM

  a recent commit changed the underlying code in asset_tag helper.

  as such this patch no longer works

  the offending code is;

  
  if ext && (File.extname(source).blank? || File.exist?(File.join(ASSETS_DIR, dir, "#{source}.#{ext}")))
    source += ".#{ext}"
  end
  

  I think it should be changed to exclude;

  
  source += ".#{ext}" unless source =~ %r{^[-a-z]+://}
  

  however I need to dry up all these calls to %r{^[-a-z]+://}

  something for the morning

• 

  Pratik March 8th, 2009 @ 12:25 AM

  • Assigned user set to “Pratik”
  • State changed from “new” to “incomplete”

  Patch doesn't apply anymore ( of course, it's been months :( ). But ok, I'll try to apply as soon as there's a new patch.

  Thanks !

• 

  CancelProfileIsBroken August 5th, 2009 @ 03:15 PM

  • Tag changed from “actionpack, assets, asset_tag_helper, javascript” to “actionpack, assets, asset_tag_helper, bugmash, javascript”

• You flagged this item as spam.
  

  MatthewRudy August 5th, 2009 @ 03:18 PM

  this just bit me again yesterday.

  I should build a patch.

• You flagged this item as spam.
  

  MatthewRudy August 5th, 2009 @ 03:49 PM

  Ok,
  here is it fixed for edge.

  BOOM!!

  • javascript_include_tag_should_not_append-js.patch 10.3 KB
• 

  Repository August 5th, 2009 @ 05:16 PM

  • State changed from “incomplete” to “resolved”

  (from [64268a0b06d32567c6e88b7293f332b79e10414b]) Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" or ".css" onto external urls [#1664 state:resolved]

  Signed-off-by: Pratik Naik pratiknaik@gmail.com
  http://github.com/rails/rails/commit/64268a0b06d32567c6e88b7293f332...

• 

  CancelProfileIsBroken August 5th, 2009 @ 05:20 PM

  • Tag changed from “actionpack, assets, asset_tag_helper, bugmash, javascript” to “actionpack, assets, asset_tag_helper, javascript”