This project is archived and is in readonly mode.

#1707 ✓stale
Chris Leishman

ActionController::Integration::request_via_redirect does not preserve headers over redirects

Reported by Chris Leishman | January 7th, 2009 @ 06:11 AM | in 3.x

ActionController::Integration::request_via_redirect does not preserve headers over redirects:

  def request_via_redirect(http_method, path, parameters = nil, headers = nil)
    send(http_method, path, parameters, headers)
    follow_redirect! while redirect?
    status
  end

The call to 'follow_redirect!' is not provided with the original headers, so instead default headers are provided. This is problematic for requests that set an explicit 'Accept' header so that respond_to will act appropriately.

Comments and changes to this ticket

  • Pratik

    Pratik March 12th, 2009 @ 04:03 PM

    • State changed from “new” to “incomplete”
    • Assigned user set to “josh”

    Could use a patch with a test!

  • josh

    josh August 19th, 2009 @ 03:46 PM

    • Assigned user cleared.
  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:03 PM

    • State changed from “incomplete” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:03 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages