This project is archived and is in readonly mode.

#1772 ✓committed
Andrew White

Regexp requirements for PathSegment broken

Reported by Andrew White | January 16th, 2009 @ 09:58 AM

The following commit:

http://github.com/rails/rails/co...

broke regexp requirements for PathSegment in a subtle way. Firstly if a regexp is specified then its passed back to build_pattern as a Regexp rather than a String as is the case with DynamicSegment. Also the the regexp in routes.rb needs to be wrapped with parenthesis for it to work which it didn't in 2.1.

This fix probably needs to be back-ported to 2.2 as well - the attached patch currently applies cleanly to both edge and 2-2-stable.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Referenced by

Pages