This project is archived and is in readonly mode.
belongs_to association to self gives SystemStackError on new_record save
Reported by Jacob Burkhart | February 9th, 2009 @ 08:33 PM | in 3.x
When creating models that associate to themselves. You get a SystemStackError "stack level too deep" when attempting to save a new one that associates to itself.
Here's a failing test.
The fix is super trivial... please apply it!
In association.rb:
change
if association.new_record?
association.save(true)
end
to
if association.new_record? && association != self
association.save(true)
end
Comments and changes to this ticket
-
Ryan Bigg April 10th, 2010 @ 11:46 AM
Please formulate in a proper patch format. See this guide: https://rails.lighthouseapp.com/projects/8994/sending-patches
-
Rishav Rastogi April 10th, 2010 @ 12:00 PM
- Tag changed from “2.3.0, activerecord, bug, callback” to “2, activerecord, bug, callback”
reproducable in 2.3.5
-
Rishav Rastogi April 10th, 2010 @ 12:03 PM
- Tag changed from “2, activerecord, bug, callback” to “2.3.x, activerecord, bug, callback”
-
Joel M April 11th, 2010 @ 07:38 AM
- Tag changed from “2.3.x, activerecord, bug, callback” to “2.3.x, activerecord, bug, callback, patch”
Patch with tests.
-
-
Santiago Pastorino February 2nd, 2011 @ 04:41 PM
- State changed from “new” to “open”
- Tag changed from “2.3.x, activerecord, bug, callback, patch” to “23x, activerecord, bug, callback, patch”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:41 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jacob Burkhart