This project is archived and is in readonly mode.
belongs_to association to self gives SystemStackError on new_record save
When creating models that associate to themselves. You get a SystemStackError "stack level too deep" when attempting to save a new one that associates to itself.
Here's a failing test.
The fix is super trivial... please apply it!
In association.rb:
change
if association.new_record?
association.save(true)
end
to
if association.new_record? && association != self
association.save(true)
end
-
belongs_to_self_test.rb
1.19 KB
-
Ryan BiggPlease formulate in a proper patch format. See this guide: https://rails.lighthouseapp.com/projects/8994/sending-patches
-
Rishav Rastogi- Tag changed from 2.3.0, activerecord, bug, callback to 2, activerecord, bug, callback
reproducable in 2.3.5
-
Rishav Rastogi
- Tag changed from 2, activerecord, bug, callback to 2.3.x, activerecord, bug, callback
-
Joel M
- Tag changed from 2.3.x, activerecord, bug, callback to 2.3.x, activerecord, bug, callback, patch
Patch with tests.
-
issue_1924.diff
2.94 KB
-
-
Santiago Pastorino
- State changed from new to open
- Tag changed from 2.3.x, activerecord, bug, callback, patch to 23x, activerecord, bug, callback, patch
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale