skip_relative_url_root is broken

+1

This bug is correct and the patch above also correct for me.
Please merge it.

:skip_relative_url_root is used for ignoring ActionController::Base.relative_url_root.

ActionController::Base.relative_url_root is needed when you run rails in relative environment
for example rails run in http://example.com/foobar/ not http://foobar.example.com/.
ActionController::Base#url_for and related methods uses this and returns correct paths, for example /foobar/users/new for new_user_path.

But you sometimes want to get paths without such paths with relative_url_root,
for example the code runs as batch kicked by mail or cron.

Though current code removes :skip_relative_url_root before they use it.
The patch above moves removing it to after use it.
This should be correct.

else

      # Delete the unused options to prevent their appearance in the query string.

•   [:protocol, :host, :port, :skip_relative_url_root].each { |k| options.delete(k) }
  

•   [:protocol, :host, :port].each { |k| options.delete(k) }
  end
  trailing_slash = options.delete(:trailing_slash) if options.key?(:trailing_slash)
  

  +

  url << ActionController::Base.relative_url_root.to_s unless options[:skip_relative_url_root]
  

So this bug and its patch is correct, please merge it.