Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• 

  Michael Koziarski March 2nd, 2009 @ 05:03 AM

  • State changed from “new” to “wontfix”

  I don't really like the API for this as it still suffers from the restriction that all joins have to have the same operator. If we were going to make this more flexible, we should make it so that the operators can be specified on a per join basis.

• You flagged this item as spam.
  

  Steffen Bartsch March 2nd, 2009 @ 08:26 AM

  I understand this objection. The syntax for per-join selection of join operators would be quite ugly, though. But it is really not helpful to resort to :include for LEFT JOINs, so what about this:

  
  Project.find(:all,
  :joins => {
    :third_parties => {:branches => :employees}},
    :project_managers
  }
  
  :joins => {
    [:left_join, :third_parties] => {
       :branches => :employees}},
    [:left_join, :project_managers]
  }
  

• 

  Michael Koziarski March 9th, 2009 @ 04:17 AM

  Yeah, that's quite ugly as you mentioned. Can we hold off making a call till after 2.3? I agree that this is something we have to look at, just don't think we should block a release on it.

• You flagged this item as spam.
  

  Steffen Bartsch March 9th, 2009 @ 04:56 PM

  Yes, this needs some more discussion. Wasn't meant to block 2.3.