Gzip / Deflate support for ActiveResource

Nice! +1

+1

Last line of the ticket:

To enable add this to your ActiveResource base class via a Mixin: base.headers['Accept-Encoding'] = 'deflate'

Is zlib packed with Rails 2.3? Because that will allow for some simplification of the patch. Too bad it's to late for 2.3.

zlib is part of the ruby standard library

Doh :) Repackaged. More tests + added an ActiveResource.enable_delfate option to set the headers for you.

+1

Prefer not adding inflate! to net/http since it inflates AS for a special case. Could you use a utility method on the connection instead?

Gzip is something that really belongs in net/http as it is something you do to a packet.

Also I think net http should really support this as every thing that does http transfers will benefit from this.

It should, but that feature should be a patch to upstream net/http rather than hiding out in Active Support.

Then Active Resource can either use net/http's inflate support or fall back to its own utility method.

Problem is that body is a private attribute of HTTP::NET, so if all the magick is in AR, it would make the patch even more ugly.

Jeremy mentions both:

Prefer not adding inflate! to net/http since it inflates AS for a special case. then..
that feature should be a patch to upstream net/http

I hope this one makes it in somewhere. Theres zero performance penalty of having this option turned off, and the ability to shorten average request duration if turned on. It meets good usability standards as well.

D

I don't really understand the problem with patching HTTP:NET. They will probably never do it upstream because of the zlib requirements. Also rails already has a truckload of mix-ins for base ruby classes (take hash for example).

And as stated above. There is no penalty if left disabled.