db:structure:dump broken by 8a5a9dc

Looks like this isn't necessary anymore. I removed the lines:

if ActiveRecord::Base.connection.supports_migrations?

File.open("db/#{RAILS_ENV}_structure.sql", "a") { |f| f << ActiveRecord::Base.connection.dump_schema_information }

end

and it works for me. It doesn't look like anything else needs to be dumped from what I can see.

I could try to make a patch for it.

Yep, deleting it restored functionality for me, too, tho I forgot to come back and mention that at some point.

Here's a patch. Hopefully this makes it in to 2.1 :)

Kyle Hargraves / Steven Soroka: Are you using migrations, and is your schema dump format set to SQL?

If so, I think I might know what the problem is. Removing those lines will "fix" it, but you will not be able to run migrations on a database created using db:structure:dump.

I'll take a look at fixing it after hearing from you guys. The fix is rather trivial, but I'd like to make sure I understand the problem first.

Jordi: Yes, I am using migrations, and the dump format is SQL. It did not occur to me to worry about whether migrations would continue to run after removing those lines, as the only use-case I have for db:structure:dump is as a dependency for db:test:clone_structure.

Ok, cool. The bad news is that the removal of those lines is not an acceptable fix.

The good news is that the fix is trivial. I'll take a look at it as soon as I can, understanding the urgency of 2.1.

My schema dump format is sql, and i'm using migrations.

I also noticed there's no db:structure:load to match the db:schema:load, which could make db:reset work regardless of ruby or sql schema types.

So has Steven's attached patch fixed the issue for you guys?

Steven's patch was sufficient to fix db:test:clone_structure, the only thing I use db:structure:dump for, but Jordi is right that it would produce databases that could not (easily) be migrated further.

Attached is a patch which restores the dump_schema_information method, updated to support the timestamped migrations.

It's Sunday morning, and you sit down to work on Rails patches ... but then you see someone else has done the work for you. Life is good.

Thanks Kyle!