AR#find_or_create doesn't add the created model to collection

I have verified this behavior by creating a new application with a failing test case:

script/generate rspec_model company name:string script/generate rspec_model client company_id:integer name:string

Then I added the associations:

class Company < ActiveRecord::Base has_many :clients end

class Client < ActiveRecord::Base belongs_to :company end

Here is a failing test case;

require File.expand_path(File.dirname(FILE) + '/../spec_helper') require 'stringio'

def redirect orig_defout = $stdout $stdout = StringIO.new yield $stdout.string ensure $stdout = orig_defout end

describe Company do it "output size from company.clients should double after two clients are created" do

company = Company.create! :name => 'AAA'
company.clients.find_or_create_by_name :name => 'client_A01'
eval_string = 'p company.clients'
output_string = redirect { eval eval_string }
first_size = output_string.size
company.clients.find_or_create_by_name :name => 'client_A02'
eval_string = 'p company.clients'
output_string = redirect { eval eval_string }
second_size = output_string.size

second_size.should == (first_size * 2)

end end

Hopefully this test case will help resolve the issue.

Sorry about the bad formatting, let me try again.

I have verified this behavior by creating a new application with a failing test case:

script/generate rspec_model company name:string
script/generate rspec_model client company_id:integer name:string

Then I added the associations:

class Company < ActiveRecord::Base
  has_many :clients
end

class Client < ActiveRecord::Base
  belongs_to :company
end

Here is a failing test case;

require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require 'stringio'

def redirect
  orig_defout = $stdout
  $stdout = StringIO.new
  yield
  $stdout.string
ensure
  $stdout = orig_defout
end

describe Company do
  it "output size from company.clients should double after two clients are created" do
    company = Company.create! :name => 'AAA'
    company.clients.find_or_create_by_name :name => 'client_A01'
    eval_string = 'p company.clients'
    output_string = redirect { eval eval_string }
    first_size = output_string.size
    company.clients.find_or_create_by_name :name => 'client_A02'
    eval_string = 'p company.clients'
    output_string = redirect { eval eval_string }
    second_size = output_string.size

    second_size.should == (first_size * 2)
  end
end

Fixed your formatting a bit. After the 3 @'s you should specify the language that's used or nothing for plain code, but not a regular line of text :)

After some additional experimentation, I learned that simply multiplying the string size was not correct. The updated spec test is below.

Not sure if it helps but essentially the issue is that the non-working test does not call the create() method in association_collection.rb instead the create() method in base.rb is called. I am stepping through an execution trace (made by Unroller) to see if I can come up with a resolution.

require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require 'stringio'

def redirect
  orig_defout = $stdout
  $stdout = StringIO.new
  yield
  $stdout.string
ensure
  $stdout = orig_defout
end

describe Company do
  it "output size from company.clients should double after two clients are created by create" do
    company = Company.create :name => 'AAA'
    company.clients.create :name => 'client_A01'
    company.clients.create :name => 'client_A02'
    eval_string = 'p company.clients'
    output_string = redirect { eval eval_string }
    output_string.size.should == 245
  end

  it "output size from company.clients should double after two clients are created by find_or_create" do
    company = Company.create :name => 'AAA'
    company.clients.find_or_create_by_name :name => 'client_A01'
    company.clients.find_or_create_by_name :name => 'client_A02'
    eval_string = 'p company.clients'
    output_string = redirect { eval eval_string }
    second_size = output_string.size
    second_size.should == 245
  end
end