This project is archived and is in readonly mode.
Association reload fails due to cached @finder_sql
Reported by Jacob Burkhart | March 11th, 2009 @ 10:37 PM | in 3.x
assuming that:
class Tag < ActiveRecord::Base
has_one :tagging
and
class Tagging < ActiveRecord::Base
belongs_to :tag
This test fails on the second assert_equal after tag.tagging.reload
def test_where_reload_assoc_fails
tag = Tag.new
ing = Tagging.new
ing.tag = tag
tag.tagging = ing
tag.save!
assert_equal(ing, tag.tagging)
tag.tagging.reload
assert_equal(ing, tag.tagging)
end
Here is an almost identical test that passes
def test_where_reload_assoc_works
tag = Tag.new
ing = Tagging.new
ing.tag = tag
tag.tagging = ing
tag.save!
assert_equal(ing, tag.tagging)
tag.reload
assert_equal(ing, tag.tagging)
end
The problem appears to be that the tag.tagging.reload uses a cached @finder_sql which was generated when the association was first referenced (when assigning the Not yet saved "ing" object to it) At that point the finder_sql was generated to include this line:
"#{@reflection.quoted_table_name}.#{@reflection.options[:as]}_id = #{owner_quoted_id} AND " +
And owner_quoted_id is nil at this point because "tag" is not yet saved.
So when we tag.tagging.reload we execute this bad cached SQL that says "tag_id = NULL"
Comments and changes to this ticket
-
-
Santiago Pastorino February 2nd, 2011 @ 04:53 PM
- State changed from “new” to “open”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:53 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jacob Burkhart
rajiv