This project is archived and is in readonly mode.
TestUploadedFile.new handles String and Pathname
Because Rails.root returns Pathname instance since Rails 2.3.
Here's patch:
-
MOROHASHI Kyosuke+1
I's better to extract base filename not by regexp but File.basename(), I think.
-
CancelProfileIsBroken- Tag changed from 2.3.2, 2.3.x, action_pack, file_field, patch, test_process to 2.3.2, 2.3.x, action_pack, bugmash, file_field, patch, test_process
-
Josh Nichols- Tag changed from 2.3.2, 2.3.x, action_pack, bugmash, file_field, patch, test_process to 2.3.2, 2.3.x, action_pack, bugmash, file_field, patch, test_process, verified
+1, because it reads a lot better, and involves a lot less crazy regexping.
Verified the patch works as expected.
-
Edd Morgan+1 Tests pass on 2-3-stable, patch works.
-
Rizwan Rezaverified
+1 Patch applies. All tests pass.
-
Rizwan Reza
not reproducible in master
+1 This is only applicable to 2-3-stable. This is probably a bug.
By adding test without code, the output in 2-3-stable is:
<"mona_lisa.jpg"> expected but was <#<Pathname:>> -
Rizwan Reza
- State changed from new to open
- Tag changed from 2.3.2, 2.3.x, action_pack, bugmash, file_field, patch, test_process, verified to 2.3.2, 2.3.x, action_pack, file_field, patch, test_process, verified
- Milestone changed from 2.x to 2.3.6
It's still applying cleanly.
-
Marius Nuennerich
Content type is image/png but filename ends in .jpg. Bug?
-
Rizwan Reza
- Tag changed from 2.3.2, 2.3.x, action_pack, file_field, patch, test_process, verified to 2.3.2, 2.3.x, action_pack, bugmash, file_field, patch, test_process, verified
-
-
-
-
-
Santiago Pastorino
- Tag changed from 2.3.2, 2.3.x, action_pack, bugmash, file_field, patch, test_process, verified to 232, 23x, action_pack, bugmash, file_field, patch, test_process, verified
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale