Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

MOROHASHI Kyosuke's latest activity

Sunday, November 22 2009
3331 [PATCH] block invalid chars to come in rails app. was updated in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke commented at 4:32 PM

    Yes. I saw rails' "before output strategy", I think it's a good way, too. Both 'before accept' and 'before output' approach is not exclusive.

    I thought several ...

Monday, October 05 2009
3331 [PATCH] block invalid chars to come in rails app. was created in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke created the ticket at 9:14 AM

    Rails fixed the XSS vulnerability caused by invalid character.
    This is the solution that new helper sanitize/cleanup invalid UTF-8
    chars BEFORE OUTPUT to browse...

Sunday, September 27 2009
3212 Almost 1 second extra in time subtraction (rails 2.3.4) was updated in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke commented at 9:27 AM

    -1 I feel new behavior more reasonable, too.

3129 [patch] better cleaning of gem directories was updated in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke commented at 9:20 AM

    +! verified on 2-3-stable w/ ruby187 and ruby192(trunk), works fine.

Tuesday, March 17 2009
2264 TestUploadedFile.new handles String and Pathname was updated in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke commented at 8:25 AM

    +1

    I's better to extract base filename not by regexp but File.basename(), I think.

Monday, March 16 2009
2249 autosaving associations skips validations and persists invalid data in the DB was updated in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke commented at 9:14 AM

    +1

    I also think this is very serious problem.

Friday, February 27 2009
2091 [PATCH] I want script/console to invoke used Ruby's irb. was created in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke created the ticket at 5:15 AM

    script/cosole script is a very good utility to develop. But it always invokes "irb" so that I can't start another irb, example irb19, without long --irb options...

Thursday, February 26 2009
2072 [PATCH] dynamic scope should reflect chained scopes was updated in Ruby on Rails
Wednesday, February 25 2009
2072 [PATCH] dynamic scope should reflect chained scopes was created in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke created the ticket at 3:28 PM

    DynamicScope ignores chaind scopes. Is'nt it bug?

    For example, Post.a_pre_defined_scope.scoped_by_author_id(1) reflects only scoped_by_author_id scope, ignores ...

Saturday, February 21 2009
2033 Ruby 1.9 compat: workaround 1.9.1p0's URI.decode bug. was updated in Ruby on Rails
  • MOROHASHI Kyosuke
    MOROHASHI Kyosuke commented at 1:08 AM

    And the this URI.decode fixation and tiny test fixation let "test_route_with_text_default (LegacyRouteSetTests)" in test_action_pack pass.

    These patches and ano...