#2033 Ruby 1.9 compat: workaround 1.9.1p0's URI.decode bug. - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2033 ✓committed

Ruby 1.9 compat: workaround 1.9.1p0's URI.decode bug.

Reported by MOROHASHI Kyosuke | February 21st, 2009 @ 01:05 AM

Ruby 1.9.1p0 has a bug on URI.decode that can'not decode multibyte chars.Now, it's been disscussed on ruby-dev ML(ruby-core in Japanese).

Since the bug aloso affect the rails, I wrote a patch to backport a disscussed solution to ActiveSupport, althrough that was'nt fixed yet in ruby-dev.

0001-Ruby-1.9.1p0-s-URI.decode-bug-fix.patch 1.8 KB

Comments and changes to this ticket

You flagged this item as spam.
MOROHASHI Kyosuke February 21st, 2009 @ 01:08 AM
And the this URI.decode fixation and tiny test fixation let "test_route_with_text_default (LegacyRouteSetTests)" in test_action_pack pass.

These patches and another (#1965) let test_action_pack task all GREEN in my environment on Ruby 1.9.1p0.
- 0002-fix-test-data-should-specify-encoding-to-use-multib.patch 1.1 KB
Repository February 21st, 2009 @ 02:43 AM
- State changed from “new” to “committed”
(from [0f93f8c4c87792c2fc0ffb044040e336edf0c43a]) Update changelog for URI.unescape fix

[#2033 state:committed] http://github.com/rails/rails/co...
Repository February 21st, 2009 @ 02:43 AM
(from [f4391c362d71efbc6d9cb66ab0aadc0593b7679e]) Update changelog for URI.unescape fix

[#2033 state:committed] http://github.com/rails/rails/co...
Jeremy Kemper February 21st, 2009 @ 02:44 AM
- Milestone cleared.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Rails Ruby on Rails

Ruby 1.9 compat: workaround 1.9.1p0's URI.decode bug.

Comments and changes to this ticket

MOROHASHI Kyosuke February 21st, 2009 @ 01:08 AM

Repository February 21st, 2009 @ 02:43 AM

Repository February 21st, 2009 @ 02:43 AM

Jeremy Kemper February 21st, 2009 @ 02:44 AM

Create your profile

Shared Ticket Bins (Sort)

People watching this ticket

Attachments

Tags

Referenced by

Pages

Rails Ruby on Rails

Keyword searching

Ruby 1.9 compat: workaround 1.9.1p0's URI.decode bug.

Comments and changes to this ticket

MOROHASHI Kyosuke February 21st, 2009 @ 01:08 AM

Repository February 21st, 2009 @ 02:43 AM

Repository February 21st, 2009 @ 02:43 AM

Jeremy Kemper February 21st, 2009 @ 02:44 AM

Create your profile

Shared Ticket Bins (Sort)

People watching this ticket

Attachments

Tags

Referenced by

Pages