This project is archived and is in readonly mode.
[patch] better cleaning of gem directories
Rails::BacktraceCleaner doesn't clean gem paths for gems that
have more than one word, or non-alpha characters in their names,
such as:
thoughtbot-factory_girl
ZenTest
db2s3
The attached patch fixes this bug (against cc1efe7e5af32789a9ed0f80528e629861dbe6a7 / master on Sep 1 2009)
-
backtrace_cleaner_gem_fix.diff
3.94 KB
-
Matt JonesA quick comment on the patch: don't use real gem names in the tests. It's been known to cause obscure and hard-to-reproduce bugs; that's why you see weird names like 'xhpricotx' in there.
-
-
CancelProfileIsBroken
- Tag changed from backtrace_cleaner, bug, patch, railties to backtrace_cleaner, bug, bugmash, patch, railties
-
Blue Box JesseBugMash +1
Code makes sense.
Patch applies successfully and tests pass.
-
Matt Jones
Patch looks great - but there's one more wrinkle that just came to mind: prerelease gems.
http://rubyforge.org/frs/shownotes.php?release_id=33411
So it's possible to have a gem directory named 'foobar-baz_mojo-1.2.3.wut', for instance.
-
Elad Meidar
+1 verified on 2-3-stable and patch applies cleanly, tests pass a well.
-
MOROHASHI Kyosuke+! verified on 2-3-stable w/ ruby187 and ruby192(trunk), works fine.
-
sr.iniv.t
+1 verified.
The patch applies on 2-3-stable and all tests pass.
-
Gaius Centus Novus
+1, verified on 2.3 stable / Ruby 1.8.6
-
Greg Hazel+1
-
Rizwan Reza- Tag changed from backtrace_cleaner, bug, bugmash, patch, railties to backtrace_cleaner, bug, patch, railties
-
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
Xavier Shay
- State changed from stale to resolved
Sadface this never got applied. In master now, the tests are still rubbish, but it appears the actual regex has been fixed. If there are still issues, they deserve a new ticket and a new patch (this won't apply to current master).
[state:resolved]