#3129 [patch] better cleaning of gem directories - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3129 ✓resolved

[patch] better cleaning of gem directories

Reported by Xavier Shay | September 1st, 2009 @ 02:20 PM

Rails::BacktraceCleaner doesn't clean gem paths for gems that have more than one word, or non-alpha characters in their names, such as:
thoughtbot-factory_girl
ZenTest
db2s3

The attached patch fixes this bug (against cc1efe7e5af32789a9ed0f80528e629861dbe6a7 / master on Sep 1 2009)

backtrace_cleaner_gem_fix.diff 3.9 KB

Comments and changes to this ticket

Matt Jones September 5th, 2009 @ 05:45 AM
A quick comment on the patch: don't use real gem names in the tests. It's been known to cause obscure and hard-to-reproduce bugs; that's why you see weird names like 'xhpricotx' in there.
You flagged this item as spam.
Xavier Shay September 10th, 2009 @ 10:41 AM
Updated patch to include Matt Jones' suggestion
- backtrace_cleaner_gem_fix.diff 4.1 KB
CancelProfileIsBroken September 25th, 2009 @ 12:36 PM
- Tag changed from “backtrace_cleaner, bug, patch, railties” to “backtrace_cleaner, bug, bugmash, patch, railties”
You flagged this item as spam.
Blue Box Jesse September 27th, 2009 @ 02:32 AM
BugMash +1

Code makes sense.

Patch applies successfully and tests pass.
Matt Jones September 27th, 2009 @ 03:14 AM
Patch looks great - but there's one more wrinkle that just came to mind: prerelease gems.

http://rubyforge.org/frs/shownotes.php?release_id=33411

So it's possible to have a gem directory named 'foobar-baz_mojo-1.2.3.wut', for instance.
You flagged this item as spam.
Elad Meidar September 27th, 2009 @ 07:42 AM
+1 verified on 2-3-stable and patch applies cleanly, tests pass a well.
You flagged this item as spam.
MOROHASHI Kyosuke September 27th, 2009 @ 09:20 AM
+! verified on 2-3-stable w/ ruby187 and ruby192(trunk), works fine.
You flagged this item as spam.
sr.iniv.t September 27th, 2009 @ 07:24 PM
+1 verified.

The patch applies on 2-3-stable and all tests pass.
You flagged this item as spam.
Gaius Centus Novus September 27th, 2009 @ 09:56 PM
+1, verified on 2.3 stable / Ruby 1.8.6
You flagged this item as spam.
Greg Hazel December 26th, 2009 @ 02:43 PM
+1
Rizwan Reza February 12th, 2010 @ 12:46 PM
- Tag changed from “backtrace_cleaner, bug, bugmash, patch, railties” to “backtrace_cleaner, bug, patch, railties”
[bulk edit]
Santiago Pastorino February 2nd, 2011 @ 04:55 PM
- State changed from “new” to “open”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:55 PM
- State changed from “open” to “stale”
You flagged this item as spam.
Xavier Shay February 2nd, 2011 @ 08:02 PM
- State changed from “stale” to “resolved”
Sadface this never got applied. In master now, the tests are still rubbish, but it appears the actual regex has been fixed. If there are still issues, they deserve a new ticket and a new patch (this won't apply to current master).

[state:resolved]