Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Xavier Shay

Xavier Shay

Not a member

Xavier Shay's latest activity

Wednesday, March 30 2011
6649 [PATCH] Add #updated support to entries in atom_feed was created in Ruby on Rails
  • Xavier Shay
    Xavier Shay created the ticket at 11:09 AM

    This is minor, but important! I will explain in code, it will be easier than words. See the commented lines, the second one is currently broken (outputs invalid...
Thursday, March 24 2011
6612 Nil HTTP user agent breaks route constraints on user_agent was updated in Ruby on Rails
  • Xavier Shay
    • Tag changed from rack routing to rack, routing
    by Xavier Shay at 3:20 AM

    Attaching rack-mount fix.
  • Xavier Shay
    Xavier Shay created the ticket at 3:20 AM

    Using the following code in routing (which is recommended on many sites) raises an exception deep inside rack if no user agent is provided by the client:

      con...
Wednesday, March 09 2011
6513 simple_format behaviour changed when used in Mailer view was updated in Ruby on Rails
  • Xavier Shay
    Xavier Shay commented at 10:44 PM

    Further, since this is only a private refactoring, there is no public or even semi-public interface to worry about breaking.
  • Xavier Shay
    Xavier Shay commented at 10:40 PM

    Any reason this can't be in 3-0-stable? There is an additional regression in that this method now raises on nil, whereas it used to return a blank string.
Wednesday, February 02 2011
3129 [patch] better cleaning of gem directories was updated in Ruby on Rails
  • Xavier Shay
    • State changed from stale to resolved
    by Xavier Shay at 8:30 PM

    Sadface this never got applied. In master now, the tests are still rubbish, but it appears the actual regex has been fixed. If there are still issues, they dese...
Monday, November 29 2010
5926 [BUG] [PATCH] Allow https URIs to be supplied for rails templates was updated in Ruby on Rails
  • Xavier Shay
    Xavier Shay commented at 3:29 AM

    This fix has not been released yet, it is scheduled for 3.0.4
Saturday, November 27 2010
5926 [BUG] [PATCH] Allow https URIs to be supplied for rails templates was updated in Ruby on Rails
  • Xavier Shay
    Xavier Shay commented at 11:42 PM

    There is already a test for http, that is currently failing on master.

    ruby -Itest test/generators/app_generator_test.rb                                       ...
Friday, November 26 2010
5926 [BUG] [PATCH] Allow https URIs to be supplied for rails templates was updated in Ruby on Rails
  • Xavier Shay
    Xavier Shay commented at 7:58 PM

    To help speed things up, please review the patch by applying it and ensuring it works as advertised, then add a +1 to this ticket.
Sunday, November 07 2010
5926 [BUG] [PATCH] Allow https URIs to be supplied for rails templates was updated in Ruby on Rails
  • Xavier Shay
    Xavier Shay commented at 10:12 AM

    I agree. My patch test is copied from another test in that file. They should both be changed (along with any others). Out of scope for this ticket.