#6612 Nil HTTP user agent breaks route constraints on user_agent - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6612 open

Nil HTTP user agent breaks route constraints on user_agent

Reported by Xavier Shay | March 24th, 2011 @ 03:20 AM | in 3.0.6

Using the following code in routing (which is recommended on many sites) raises an exception deep inside rack if no user agent is provided by the client:

  constraints :user_agent => /MSIE 6/i do
    get 'admin' => redirect('/unsupported_browser')
  end

Not sure where the correct place to fix this is, but attached is one option in two diffs:
1) Failing test against rails master
2) Fix for rack-mount

user_agent_failing_test.diff 970 Bytes

Comments and changes to this ticket

You flagged this item as spam.
Xavier Shay March 24th, 2011 @ 03:20 AM
- Tag changed from “rack routing” to “rack, routing”
Attaching rack-mount fix.
- user_agent_rack_mount_fix.diff 909 Bytes
Andrew White March 24th, 2011 @ 01:23 PM
- State changed from “new” to “open”
- Milestone set to “3.0.6”
- Assigned user set to “Andrew White”
- Importance changed from “” to “Low”