Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Updates tests to cause the tests for the Request class not to proxy through a fake TestRequest object.

#2278

The tests for the Request class proxied everything through a TestRequest class. This patch updates the tests to exercise Request directly and hopefully make the tests less fragile.

Reported by David Dollar · March 17th, 2009 @ 09:41 PM

State: resolved
Milestone: 2.x
Assigned to: josh josh
Importance: none

Activity

  1. David Dollar
    David Dollar

    These tests should actually be far more accurate as well as they exercise the Request methods using HTTP environment variables rather than magic accessors.

    March 17th, 2009 @ 09:44 PM

  2. Pratik
    Pratik
    • Assigned user set to josh

    March 17th, 2009 @ 09:55 PM

  3. Repository
    Repository
    • State changed from new to resolved

    (from [dace54b2e9bcdb49ffa43b204c3a8959c55f1276]) Updates tests to cause the tests for the Request class not to proxy through a fake TestRequest object [#2278 Updates tests to cause the tests for the Request class not to proxy through a... state:resolved]

    Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

    March 24th, 2009 @ 03:54 PM

  4. Repository
    Repository

    (from [4c2f09f23a05823b076cdfb8ac39934e0678798a]) Updates tests to cause the tests for the Request class not to proxy through a fake TestRequest object [#2278 Updates tests to cause the tests for the Request class not to proxy through a... state:resolved]

    Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

    March 24th, 2009 @ 03:54 PM