ActiveRecord::Rollback does not nil all id attributes

Following the clues I just arrived to this method into active_record/transactions.rb:

# Reset id and @new_record if the transaction rolls back.
    def rollback_active_record_state!
      id_present = has_attribute?(self.class.primary_key)
      previous_id = id
      previous_new_record = new_record?
      yield
    rescue Exception
      @new_record = previous_new_record
      if id_present
        self.id = previous_id
      else
        @attributes.delete(self.class.primary_key)
        @attributes_cache.delete(self.class.primary_key)
      end
      raise
    end

When I executes the test that @porras uploaded the condition has_attribute?(self.class.primary_key) is false so the method doesn't modify the id, but I don't understand why it's returning false.

I'm just thinking there is a worst problem in this method. What happen when a user doesn't follow the convention and changes the name of the primary key attribute? I suppose these lines will raise an error because the id method won't be defined:

line 206: previous_id = id
line 212: self.id = previous_id

@calavera it's not related. AR wraps each save (and its validations and callbacks) in a transaction (which is nested if you already have one opened). That's the transaction being rolled back there, not the big one. That is: if you have a transaction with 5 saves and the last one fails, the 5 saves are rolled back, but only the object whose save failed gets its id fixed.

Anyway, your issue with hardcoding 'id' is completely true.

ok. I'm opening a new ticket so XD