#2347 Patch that adds an exception - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2347 ✓invalid

Patch that adds an exception

Reported by nasmorn | March 26th, 2009 @ 01:34 PM | in 3.x


<%= link_to 'bla', '#', {:onclick => "document.merge_form.submit()", :confirm => "Really?"}%>

will result in


<a onclick="return confirm('Really?');" href="#">bla</a>

with my onclick just eaten without any notice. If this isn't done for a specific reason I would propose 2 possible solutions. Allow only one of the two being set and throw an exception Wrap the onclick JS in the confirm

I totally understand that I will have to write the patch myself and just wanted to check if this is not for some reason intended behaviour, if it is I could add a comment on this to the link_to method.

Comments and changes to this ticket

You flagged this item as spam.
Jeff April 5th, 2009 @ 10:07 PM
- Tag changed from “action_view, javascript, link_to” to “action_view, javascript, link_to”
I can't speak to what the intention is here, but if you look at the documentation for the link_to_function method, you'll one example of what you're trying to do
```
  link_to_function(image_tag("delete"), "if (confirm('Really?')) do_delete()")
```
http://api.rubyonrails.org/class...

Maybe raising an exception or a warning would be a good idea, but I'm not sure that wrapping the onclick in the confirm is obvious.
You flagged this item as spam.
nasmorn April 6th, 2009 @ 02:41 PM
- Tag changed from “action_view, javascript, link_to” to “action_view, javascript, link_to, patch”
- Title changed from “:confirm overwrites :onclick” to “Patch that adds an exception”
I hope this is acceptable, it does pretty much what the other exception does
- url_helper.diff 661 Bytes
Jeremy Kemper May 4th, 2010 @ 06:48 PM
- Milestone changed from “2.x” to “3.x”
[bulk edit]
Ryan Bigg October 6th, 2010 @ 02:10 AM
- State changed from “new” to “incomplete”
- Importance changed from “” to “Low”
Please add tests to this patch.
Ryan Bigg October 6th, 2010 @ 02:11 AM
- Tag changed from “action_view, javascript, link_to, patch” to “action_view, needs_tests”
You flagged this item as spam.
Ben Mills October 6th, 2010 @ 02:58 AM
- Assigned user set to “Ryan Bigg”
In Rails master seems to do just what it should. Rails 3 utilizes the HTML5 attribute data-confirm to handle the confirmation.
```
<%= link_to 'bla', '#', {:onclick => "document.merge_form.submit()", :confirm => "Really?"}%>
```
Outputs:
```
<a href="#" data-confirm="Really?" onclick="document.merge_form.submit()">bla</a>
```
Since it seems unnecessary, my vote:

-1
Ryan Bigg October 9th, 2010 @ 10:14 PM
- Tag cleared.
Automatic cleanup of spam.
Ryan Bigg October 19th, 2010 @ 08:23 AM
Automatic cleanup of spam.
Jeff Kreeftmeijer November 8th, 2010 @ 08:49 AM
Automatic cleanup of spam.
Piotr Sarnacki December 17th, 2010 @ 10:36 AM
- State changed from “incomplete” to “invalid”
I'm closing that. As Ben noticed, 3.x is no longer adding stuff to onclick attribute.
You flagged this item as spam.
bingbing March 26th, 2011 @ 01:14 AM
luxury watch