This project is archived and is in readonly mode.
with_scope doesn't need &block parameter
Reported by James Le Cuirot | March 27th, 2009 @ 03:24 PM | in 2.x
I gather that adding a &block parameter to your method signature can impact performance. In the case of with_scope, the parameter actually isn't used so it should be removed.
Comments and changes to this ticket
-
Steve St. Martin April 15th, 2010 @ 11:40 PM
- Assigned user set to “Ryan Bigg”
documentation http://api.rubyonrails.org/classes/ActiveRecord/Base.html#M002311 shows allowed use of a block, removing this would cause compatibility issues, so this should be set to a major release, however being much of activerecord and scopes have been rewritten in rails 3 this likely no longer applies
suggesting to be marked as wontfix
-
Ryan Bigg April 15th, 2010 @ 11:42 PM
- State changed from “new” to “invalid”
with_scope does need the &block parameter.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
James Le Cuirot
Ryan Bigg