Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

with_scope doesn't need &block parameter

#2359

I gather that adding a &block parameter to your method signature can impact performance. In the case of with_scope, the parameter actually isn't used so it should be removed.

Reported by James Le Cuirot · March 27th, 2009 @ 03:24 PM

State: invalid
Milestone: 2.x
Assigned to: Ryan Bigg Ryan Bigg
Importance: none

Activity

  1. Steve St. Martin
    Steve St. Martin
    • Assigned user set to Ryan Bigg

    documentation http://api.rubyonrails.org/classes/ActiveRecord/Base.html#M002311 shows allowed use of a block, removing this would cause compatibility issues, so this should be set to a major release, however being much of activerecord and scopes have been rewritten in rails 3 this likely no longer applies

    suggesting to be marked as wontfix

    April 15th, 2010 @ 11:40 PM

  2. Ryan Bigg
    Ryan Bigg
    • State changed from new to invalid

    with_scope does need the &block parameter.

    April 15th, 2010 @ 11:42 PM