This project is archived and is in readonly mode.
Prevent Dependencies.new_constants_in cleanup code masking real error when collecting watch_frames fails
Reported by Tom Ward | April 19th, 2008 @ 04:28 PM
Previously, the code collecting watch_frames could fail leaving watch_frames
defined but nil. The cleanup code checked watch_frames is defined, but not that it holds a value, raising an undefined method on NilClass error rather than the original cause. This can make debugging the underlying problem a total pain.
My (very simple) patch fixes this:
Comments and changes to this ticket
-
josh April 19th, 2008 @ 10:24 PM
- Assigned user set to “Jeremy Kemper”
- State changed from “new” to “open”
-
-
Pratik May 20th, 2008 @ 11:50 AM
- State changed from “open” to “resolved”
Fixed in http://github.com/rails/rails/co...
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeff Kreeftmeijer
Jeremy Kemper
Pratik
Tom Ward
Referenced by
-
87
Dependencies shouldn't swallow errors from required files.
That specific problem (the plugin-with-hyphenated-name) ...