accepts_nested_attributes_for does't work when nested_attributes hash has an :id entry

(from [0dbe0f670e08e6adfedc395dadb9859ca2df6d4b]) Raise a RecordNotFound if an ID in nested attributes is given but doesn't return a record. [#2415 state:resolved] http://github.com/rails/rails/commit/0dbe0f670e08e6adfedc395dadb985...

This patch does help clarify what is going on, but does not solve the issue when creating a new object.

For example:

Order model:

class Order < ActiveRecord::Base
belongs_to :customer accepts_nested_attributes_for :customer end

Parameters:

{"action"=>"create", "authenticity_token"=>"ZXdeEAgTsQFIihAFgVBaTsf9GR6o/cuCNmphc4OaMzU=", "order"=>{ "customer_attributes"=>{"company"=>"TestCompany", "phone_alt"=>"555-555-8251", "id"=>"101", "last_name"=>"Jones", "phone"=>"", "fax"=>"555-222-3333", "first_name"=>"Bob", "email"=>"bob@notreal.com"}, "invoice_comments"=>"", "customer_id"=>"101"} }

Results in:

ActiveRecord::RecordNotFound (Couldn't find Customer with ID=101 for Order with ID=):

To further explain, the use-case-scenario of this is that I am building a system where there will be an order form, and in this order form there is a nested form for a customer. The goals of the application are to both allow the user to create a new order, and simultaneously associate this new order with a given customer (in this case customer id 101) and also if they choose update the customers information at the same time. (IE - the customer has made orders in the past, but calls in to make a new order today, and also gives a new phone number. no need to go back to another form to update the phone number when you should just be able to do it from the order form.)

For fun I have also tried to omit params[:order][:customer_id] = 101, but this does not make a difference. Tried this with the http://github.com/rails/rails/commits/2-3-stable branch checked out moments ago.

Thanks for any light you can shed!

As Scoot Rushforth described it, the patch doesn't solve the problem. The ActiveRecord::RecordNotFound exception should be raised only if the nested record is not found, not when the association is missing. In that case a new association in the join table should be created.

The description of the method assign_nested_attributes_for_collection_association (nested_attributes.rb) says:

Hashes with an :id value matching an existing associated record will update that record. Hashes without an :id value will build a new record for the association. Hashes with a matching :id value and a :_destroy key set to a truthy value will mark the matched record for destruction.

If the id is not passed, a new record and a new association will be created.

If the id is passed, the record will be updated (as described), but the association should be checked/created as well.

In a nested form, the user should be able to either create a new (nested) record, or choose an existing one. Currently, choosing an existing record results in the ActiveRecord::RecordNotFound error.

This ticket breaks our application. I've distilled it down to http://github.com/radar/rails-test-app/tree/anaf_has_one.

This patch should duplicate the issue, but it's not. I have to leave work now (end of the day). As far as I know, this is what is happening.

It seems, this bug is a side effect of another bug: 4766.

running into the same issue with belongs_to relationships.

We need a failing test case in order to apply any patch. Thanks!

Thanks for the note José. Attached is an updated test (which found issues in my patch.) and an updated patch (thanks to the tests).

Apply the tests patch to see the issues. Apply the code patch to fix the tests.

Same for me.

class Part < ActiveRecord::Base
end

class Partquantity < ActiveRecord::Base
belongs_to :part

also same problem with has_one

accepts_nested_attributes_for :part end

<% form_for(@partquantity) do |pq_form| %>
<%= pq_form.error_messages %>

<% pq_form.fields_for :part do |part_form| %>

 <%= part_form.label :id, 'Select Part:' %>
 <%= part_form.select :id,  options_from_collection_for_select(@parts, 'id', 'code') %>

Form submission results in the rollowing request attributes:
{"authenticity_token"=>"K0AhiY3Uozqj9VpgqhswgXcNMNuO2Yzfgfp3xOgsQrs=", "partquantity"=>{"part_attributes"=>{"id"=>"2"}, "quantity"=>"ii"}, "commit"=>"Create"}

and when I do @partquantity = Partquantity.new(params[:partquantity) I get:

Couldn't find Part with ID=2 for Partquantity with ID=

Hey George, thanks for the patch! Just two notes: could you please create them using the format described here:

http://rails.lighthouseapp.com/projects/8994/sending-patches

Also, it would be better if you used "reflect_on_association(association_name)" to retrieve associations (since it's the official API) instead of "reflections[association_name]".

Thanks a bunch!

George, I already applied in the 2-3-stable branch. Could you please provide a patch for master?

This is preliminary, but I just installed 2-3-stable. It fixed one-level-deep nested attribute updating, but I am still seeing a problem when there is more than one level of nesting. In that case, it is looking like the "grandchildren" records are only updated if at least one attribute changes in the related "child" record. Otherwise, no update is done on the grandchildren.

It's quite possible that this is my problem...anyone else?

I'm also having the same problem with the update_attributes when using a two level deep nested resources. It will update the first level child but not the second level one. Should we open a new ticket or keep going in this one?

@Rafael did you try with rails edge?

If it is still an issue please open a new ticket and refer to this ticket as 'related'. Yours is related to grandchildren while original ticket is related to children. So lets keep them separate.

@Neeraj I did not before, I just did check and in fact it is correct for the 2.3.9 version. Thank you.

http://github.com/rails/rails/commit/96183e0f284bab27667e5a38fa6a15... due to CVE-2010-3933 rolled this patch back. We'll have to reopen.