This project is archived and is in readonly mode.
PostgreSQL schema dumper does not support capitalized table names
-
Michael Koziarski
Can you rebase these down into a single patch, and ideally someone with the postgres gem can verify it. I'm also pg gem on 10.5
-
Scott Woods
I had to revise my patch a bit, since the patch from #390 postgres adapter quotes table name, breaks when non-default schema is used got committed yesterday, which implemented even more complete table-name quoting than I had.
So the new patch does the following:
- Quotes the table name when casting to regclass so that capitalized table names are supported. Does so using the new quote_table_name method from #390 postgres adapter quotes table name, breaks when non-default schema is used.
- Adds tests for capitalized table names, including when the occur with prefixed schema names (the purpose of #390 postgres adapter quotes table name, breaks when non-default schema is used).
I've rebased against master and consolidated into a single diff.
-
Scott Woods
Verified against the postgres (0.7.9.2008.01.28) gem.
- MacOS 10.5 Leopard
- PostgreSQL 8.2.11
-
clinton
- I ran all tests successfully, against the master. Code makes sense.
Mac OS X 1.5, PostgreSQL 8.3.6.
-
Max Lapshin
- Tag changed from activerecord, adapters, camelcase, patch, postgresql, schema, tables to activerecord, adapters, bug, camelcase, patch, postgresql, schema, tables, verified
- Assigned user set to Tarmo Tänav
I was afraid, that this code will fail, when declaring table in other schema, but it worked for me! Checked against post-2.3.2 master
P.S. Am I right, changing its state to verified?
-
Repository
- State changed from new to resolved
(from [64b33b6cf9db508d2c12394cc1a3f36c91fb2eed]) Quote table names when casting to regclass so that capitalized tables are supported. [#2418 PostgreSQL schema dumper does not support capitalized table names state:resolved]
Signed-off-by: Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/co...
-
Repository
(from [70ba90b072025b89248606178ee30d2ff12301c4]) Quote table names when casting to regclass so that capitalized tables are supported. [#2418 PostgreSQL schema dumper does not support capitalized table names state:resolved]
Signed-off-by: Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/co...
