Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

build_association nullifies existing model object in has_one association

#2432

I have:

class Student < ActiveRecord::Base

has_one :language_grade

end

class LanguageGrade < ActiveRecord::Base

belongs_to :student

end

I do:

>> s=Student.create(:name=>"Norm")

=> #<Student id: 1, name: "Norm", created_at: "2009-04-06 13:43:09", updated_at: "2009-04-06 13:43:09">

>> s.language_grade

=> nil

>> s.create_language_grade(:score=>88)

=> #<LanguageGrade id: 1, student_id: 1, score: 88, created_at: "2009-04-06 13:43:46", updated_at: "2009-04-06 13:43:46">

>> LanguageGrade.all

=> [#<LanguageGrade id: 1, student_id: 1, score: 88, created_at: "2009-04-06 13:43:46", updated_at: "2009-04-06 13:44:13">]

>> s.build_language_grade(:score=>44)

=> #<LanguageGrade id: nil, student_id: 1, score: 44, created_at: nil, updated_at: nil>

>> LanguageGrade.all

=> [#<LanguageGrade id: 1, student_id: nil, score: 88, created_at: "2009-04-06 13:43:46", updated_at: "2009-04-06 13:44:13">]

You can see that simply invoking build_language_grade caused the existing model object in the database to be "nullified". According to the documentation, build_association should simply create a model instance in memory... the database should be unaffected, and the database object should definitely not be nullified.

Reported by Les Nightingill · April 6th, 2009 @ 08:45 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Mark Dodwell
    Mark Dodwell

    I'm also seeing this behaviour. Seems very undesirable, surprised nobody else has commented yet.

    Are other people seeing this?

    January 31st, 2010 @ 07:15 PM

  2. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Tag changed from 2.2.2, association, has_one to 222, association, has_one
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:39 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:39 PM