This project is archived and is in readonly mode.

#2450 ✓stale

ActionController::Response::set_conditional_cache_control! should set only private headers if session is started

Reported by runa | April 7th, 2009 @ 11:31 PM | in 3.x

While working in setting up a reverse proxy in front of Rails, I found that ActionController::Response::set_conditional_cache_control! sets the Cache-Control headers as 'private, max-age=0, must-revalidate' when this should be only set if the session was started.

Given all the caching efforts in this module (see etag generation & more) this line is a step backwards.

Also I find the default header (no-cache) to have the same effect: this header should be sent if and only if sessions are started.

If we don't want ppl to complain about rails being slow we need to make it faster by default.

See attached small patch against 2.3.2

Comments and changes to this ticket

  • runa
  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “new” to “open”
    • Tag changed from 2.3.2, cache, cache-control, performance, scalability, session to 232, cache, cache-control, performance, scalability, session
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket