[PATCH] active_record/schema_dumper.rb gets confused by a non-integer column named "id"

I'm bringing this patch back up, it was originally posted on Rails Trac at http://dev.rubyonrails.org/ticke.... I would still find it useful and request it get applied.

If you have a migration that looks like this:

class CreateThing < ActiveRecord::Migration

def self.up

    create_table :things, :id => false do |t|

        t.text :id, :null => false

        t.text :blah, :null => false

    end

...

The schema dumper will render you a table that looks like this:

create_table "things", :force => true do |t|

    t.text "blah", :null => false

end

This will cause your fixtures to break, because it expects a non-integer column named "id", but the schema.rb is creating an integer column named id.

The possibly easy fix is to change the "def table(table, stream)" in active_record/schema_dumper.rb to check the column type before assuming that the "id" column is an integer. If it's not then add ":id => false" to the create_table call and just use :id like any other column. I say "possibly" easy because I don't know if the magic id column is being used differently in other areas of the dumper, or if this is the only place.