This project is archived and is in readonly mode.
[PATCH] active_record/schema_dumper.rb gets confused by a non-integer column named "id"
Reported by Andy Orahood | April 9th, 2009 @ 10:07 PM | in 3.x
I'm bringing this patch back up, it was originally posted on Rails Trac at http://dev.rubyonrails.org/ticke.... I would still find it useful and request it get applied.
If you have a migration that looks like this:
class CreateThing < ActiveRecord::Migration
def self.up
create_table :things, :id => false do |t|
t.text :id, :null => false
t.text :blah, :null => false
end
...
The schema dumper will render you a table that looks like this:
create_table "things", :force => true do |t|
t.text "blah", :null => false
end
This will cause your fixtures to break, because it expects a non-integer column named "id", but the schema.rb is creating an integer column named id.
The possibly easy fix is to change the "def table(table, stream)" in active_record/schema_dumper.rb to check the column type before assuming that the "id" column is an integer. If it's not then add ":id => false" to the create_table call and just use :id like any other column. I say "possibly" easy because I don't know if the magic id column is being used differently in other areas of the dumper, or if this is the only place.
Comments and changes to this ticket
-
Hongli Lai July 5th, 2009 @ 09:19 AM
It's not good to remove "pk ||= 'id'" because @connection.pk_and_sequence_for can return nil.
I'm also not sure whether your approach is a good idea. Wouldn't it be better to do this?
1. If the PK is an integer but not called "id", then output create_table "foo", :primary_key => whatever
2. If the PK is not an integer, then do not output create_table "foo", :primary_key => whatever. Instead, output t.primary_key(pk column name here, type), and modify the #primary_key method to allow specifying a type. -
-
Santiago Pastorino February 2nd, 2011 @ 05:03 PM
- State changed from “new” to “open”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 05:03 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Hongli Lai
James Herdman