This project is archived and is in readonly mode.

assert_redirected_to should surface the message in all fail cases

#2477

Based on the current source (Rails 2.3.2), when assert_redirected_to fails due to the response redirect not matching the expected redirect the user-supplied message (second parameter) is not shown. This message is only shown if the response is not a redirect.

Example functional test code:


test "ensure all actions are protected" do
  %w{ index new create edit update destroy }.each do |action|
    get action
    assert_redirected_to login_path, "Expected redirect to login page for action: #{ action }"
  end
end

Corresponding controller code:


def index
  redirect_to some_other_page_path
end@@@

Reported by justin · April 10th, 2009 @ 05:35 PM

Activity

David Trasbo
I've attached a tiny patch which fixes this.
- assert_redirected_to_message.patch 1.2 KB
April 14th, 2010 @ 09:44 PM
Jeremy Kemper
- Milestone changed from 2.x to 3.x
[bulk edit]

May 4th, 2010 @ 06:48 PM
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 05:03 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 05:03 PM