This project is archived and is in readonly mode.
Rails::Rack::Static no longer seeing page cached files when page cache directory is moved
Setup:
class FooController < ActionController::Base
caches_page :bar
def bar
end
end
- Start script/server in production mode.
- Hit http://localhost:3000/foo/bar. An entry should show in the log for the action. public/foo/bar.html should exist.
- Refresh. Nothing should show in the log as Mongrel loads the cached file.
Nothing out of the ordinary so far...
Put this in environment.rb:
config.action_controller.page_cache_directory = RAILS_ROOT + "/public/cache"
- rm public/foo/bar.html, restart Mongrel
- Fire up http://localhost:3000/foo/bar again. As before, the log should show Rails handled the request.
- Refresh. Nothing should show in the log but in fact Rails loads the action again.
I tracked this issue down to Rails::Rack::Static failing to take ActionController::Base.page_cache_directory into account when looking for a cache file. Attached is a patch that fixed the problem for me. I didn't see any place I could write a test for this, but maybe I didn't look far enough.
-
rails-rack-static-page-cache-fix.diff
991 Bytes
-
sergey.kojinI have simpler solution, just
In@file_server = ::Rack::File.new(ActionController::Base.page_cache_directory)
def initialize(app) @app = app @file_server = ::Rack::File.new(File.join(RAILS_ROOT, "public")) end -
-
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
divineforest
Have the same problem
-
divineforest
Sorry, it works now :)