#2600 Quote table name in JoinAssociation - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2600 ✓resolved

Quote table name in JoinAssociation

Reported by Rob Anderton | May 2nd, 2009 @ 11:28 AM

This commit fixes aliased table names in JoinAssociations with hash conditions: http://github.com/rails/rails/co...

It should really be quoting the aliased table name, like the rest of the method, shouldn't it? Here's a quick patch for it.

quote_aliased_table_name_for_hash_conditions_in_join_association.diff 1.2 KB

Comments and changes to this ticket

Pratik May 17th, 2009 @ 05:59 PM
- State changed from “new” to “incomplete”
Hey Rob,

Patch should have a failing test case too.
CancelProfileIsBroken August 6th, 2009 @ 02:42 PM
- Tag changed from “activerecord, assocation, patch, quoted_table_name” to “activerecord, assocation, bugmash, patch, quoted_table_name”
You flagged this item as spam.
dira August 8th, 2009 @ 04:50 PM
not reproducible

Already included (tests & patch):
http://github.com/rails/rails/blob/482a6f716fab5ea6431e15ee2603b62a...
CancelProfileIsBroken August 9th, 2009 @ 03:02 AM
- Tag changed from “activerecord, assocation, bugmash, patch, quoted_table_name” to “activerecord, assocation, patch, quoted_table_name”
- State changed from “incomplete” to “resolved”
You flagged this item as spam.
Rob Anderton August 9th, 2009 @ 03:09 PM
- Tag changed from “activerecord, assocation, patch, quoted_table_name” to “activerecord, assocation, patch, quoted_table_name”
Woah there chaps, it's still broken: I've attached an updated (and more complete) patch with a test that'll apply to both master and 2-3-stable.
- quote_aliased_table_name_v2.diff 4.7 KB
You flagged this item as spam.
Rob Anderton August 9th, 2009 @ 03:10 PM
- Tag changed from “activerecord, assocation, patch, quoted_table_name” to “activerecord, assocation, bugmash, patch, quoted_table_name”
Adding bag the bugmash tag...
CancelProfileIsBroken August 9th, 2009 @ 05:13 PM
- Assigned user cleared.
- Tag changed from “activerecord, assocation, bugmash, patch, quoted_table_name” to “activerecord, assocation, patch, quoted_table_name”
- Milestone cleared.