Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Quote table name in JoinAssociation

#2600

This commit fixes aliased table names in JoinAssociations with hash conditions: http://github.com/rails/rails/co...

It should really be quoting the aliased table name, like the rest of the method, shouldn't it? Here's a quick patch for it.

Reported by Rob Anderton · May 2nd, 2009 @ 11:28 AM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Pratik
    Pratik
    • State changed from new to incomplete

    Hey Rob,

    Patch should have a failing test case too.

    May 17th, 2009 @ 05:59 PM

  2. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from activerecord, assocation, patch, quoted_table_name to activerecord, assocation, bugmash, patch, quoted_table_name

    August 6th, 2009 @ 02:42 PM

  3. dira
  4. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from activerecord, assocation, bugmash, patch, quoted_table_name to activerecord, assocation, patch, quoted_table_name
    • State changed from incomplete to resolved

    August 9th, 2009 @ 03:02 AM

  5. Rob Anderton
    Rob Anderton
    • Tag changed from activerecord, assocation, patch, quoted_table_name to activerecord, assocation, patch, quoted_table_name

    Woah there chaps, it's still broken: I've attached an updated (and more complete) patch with a test that'll apply to both master and 2-3-stable.

    August 9th, 2009 @ 03:09 PM

  6. Rob Anderton
    Rob Anderton
    • Tag changed from activerecord, assocation, patch, quoted_table_name to activerecord, assocation, bugmash, patch, quoted_table_name

    Adding bag the bugmash tag...

    August 9th, 2009 @ 03:10 PM

  7. CancelProfileIsBroken
    CancelProfileIsBroken
    • Assigned user cleared.
    • Tag changed from activerecord, assocation, bugmash, patch, quoted_table_name to activerecord, assocation, patch, quoted_table_name
    • Milestone cleared.

    August 9th, 2009 @ 05:13 PM