This project is archived and is in readonly mode.

#2603 ✓committed
Chris Kampmeier

Use of #tap before requiring Active Support breaks on Ruby 1.8.6

Reported by Chris Kampmeier | May 4th, 2009 @ 02:12 AM | in 2.x

Commit 945bf9c2 breaks Active Record on versions of Ruby that don't have a native #tap (like 1.8.6), because it tries to use #tap about two lines before Active Support is available :)

When I try to run the AR tests on OS X's 1.8.6p114, I get this:

/Users/chrisk/Documents/railstest/rails/activerecord/test/cases/../../lib/active_record.rb:24: undefined method `tap' for #<String:0x11ca1a0> (NoMethodError)

A simple fix is to go back to the previous way of handling the string, just using a local variable. This fixes the test suite for me. I've attached a patch.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket


Referenced by