Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

BlankSlate.reveal(name) doesn't work with blocks

#2640

Vendor-ed Builder gem v.2.1.2 has broken reveal(..) method. It doesn't support definition of revealing methods which need support of blocks.

Here's current implementation of BlankSlate.reveal() method:

def reveal(name)
  bound_method = nil
  unbound_method = find_hidden_method(name)
  fail "Don't know how to reveal method '#{name}'" unless unbound_method
  define_method(name) do |*args|

bound_method ||= unbound_method.bind(self)
bound_method.call(*args)



end end

Here's one which works fine:

def reveal(name)
  bound_method = nil
  unbound_method = find_hidden_method(name)
  fail "Don't know how to reveal method '#{name}'" unless unbound_method
  define_method(name, unbound_method)
end

Example:

class MyClass < BlankSlate


reveal :returning


def just_method returning do

 return 'testing return value'



end end
end

I've tried implement this as current implementation with block support like:

def reveal(name)
  bound_method = nil
  unbound_method = find_hidden_method(name)
  fail "Don't know how to reveal method '#{name}'" unless unbound_method
  define_method(name) do |*args, &block|

bound_method ||= unbound_method.bind(self)
bound_method.call(*args, &amp;block)



end end

But because Ruby 1.8 doesn't support this syntax and it's going to work only on 1.9 I've decided to use old way with passing name:

  ...
  define_method(name, unbound_method)
  ...

Reported by Ladislav Martincik · May 13th, 2009 @ 02:08 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:50 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:50 PM

  4. bingbing